Notifying user if an already existing user is added#13852
Closed
gsunit wants to merge 5 commits intoRocketChat:developfrom
gsunit:check-user-exists-in-room
Closed
Notifying user if an already existing user is added#13852gsunit wants to merge 5 commits intoRocketChat:developfrom gsunit:check-user-exists-in-room
gsunit wants to merge 5 commits intoRocketChat:developfrom
gsunit:check-user-exists-in-room
Conversation
Contributor
|
@gsunit I think it would be better if along with the toastr message we can add that users already in the channel are not displayed in the autocomplete popup list. |
Contributor
Author
|
Thanks, @bharadwajaditya! Can be easily done. But then there will be no notifications. Let's wait for the reviewers and see what they have to say. |
Contributor
|
@gsunit yeah sure. This was just my idea for this issue. Since you are working on it so it will be easy for you to implement it. |
|
@gsunit I was also working on this issue ! my bad I didn't saw the issue referenced. |
Contributor
Author
|
Closing this PR due to conflicts. Opening a new PR for the same feature, please have a look at PR #14142 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, a success
toastris displayed even if an already existing user is added to a channel. With this we can issue an elegant little notification, which is only visible to the user, that says$username is already in here.Closes #13837