Notify if user already exists in room#14142
Closed
gsunit wants to merge 6 commits intoRocketChat:developfrom
gsunit:notify-user-already-exists
Closed
Notify if user already exists in room#14142gsunit wants to merge 6 commits intoRocketChat:developfrom gsunit:notify-user-already-exists
gsunit wants to merge 6 commits intoRocketChat:developfrom
gsunit:notify-user-already-exists
Conversation
Merge commit
Merge commits
update branch
MarcosSpessatto
suggested changes
May 16, 2019
| }); | ||
| } | ||
| addUserToRoom(data.rid, newUser, user); | ||
| // addUserToRoom(data.rid, newUser, user); |
Contributor
Author
There was a problem hiding this comment.
I see that you have opened a new PR. Thanks! Should I close this one?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A solution to issue #13879. With this we can issue an elegant little notification, which is only visible to the user if a the user invites an already existing member to a room.