Fix discussions issues after room deletion and translation actions not being shown#14018
Merged
sampaiodiego merged 8 commits intodevelopfrom Apr 8, 2019
Merged
Fix discussions issues after room deletion and translation actions not being shown#14018sampaiodiego merged 8 commits intodevelopfrom
sampaiodiego merged 8 commits intodevelopfrom
Conversation
sampaiodiego
requested changes
Apr 6, 2019
sampaiodiego
requested changes
Apr 6, 2019
| message.translations = {}; | ||
| } | ||
| if (subscription && subscription.autoTranslate !== message.autoTranslateShowInverse) { | ||
| if (!!(subscription && subscription.autoTranslate) !== !!message.autoTranslateShowInverse) { |
Member
There was a problem hiding this comment.
this is confusing, what is the motivation here?
if the code cannot be made clear, please add a comment describing what it is doing.
sampaiodiego
changed the title
sampaiodiego
approved these changes
Apr 8, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13689
Closes #13965