fix discussions: remove restriction for editing room info, server side

[mrsimpson]

Closes #14027

@ggazzo Obviously, you restricted editing the discussion's room info not by accident ;) I just tested removing the restrictions and can't see a reason why one should not edit it. Also changing the name was stable: The navigation was working after that as well.

Only deleting the discussion will lead to an orphaned "discussion-created-message" in the parent channel. This will lead to a "not allowed" message just like a navigation to a discussion you are not a member of.

[ggazzo]

@mrsimpson about the orphan message: #14018

[ggazzo]

we are using topic field to set the parent name, so sure we can enable edition but we should block topic changes...

look Rocket.Chat/app/channel-settings/client/views/channelSettings.html and Rocket.Chat/app/channel-settings/client/views/channelSettings.js

and use something like roomTypes.getConfig(room.t).allowRoomSettingChange(room, RoomSettingsEnum.TOPIC)) {

[mrsimpson]

@ggazzo in our practice it has shown that if somebody wants to change the topic (“re-assign it to some other topic”) there’s a good reason for that. And since the topic property is not technically needed for the relationship, I don’t see a reason why to block editing.

_{Sent with GitHawk}