[NEW] Show user's status description by the usernames in messages list#14892
Merged
ggazzo merged 5 commits intoRocketChat:developfrom May 8, 2020
Merged
[NEW] Show user's status description by the usernames in messages list#14892ggazzo merged 5 commits intoRocketChat:developfrom
ggazzo merged 5 commits intoRocketChat:developfrom
Conversation
Contributor
|
@wreiske This is super tricky. Due to performance issues, the BTW, should this feature not be added only after setting an emoji for a custom status? I believe this was removed from the feature, right? |
Contributor
Author
I was thinking to do this one in steps... adding emojis to a status text, and assigning an emoji to a message is two different things.
If there is no emoji set for the status, it shows the bubble.
If we can figure out how to update this, I think it will be OK as the current bubble icon. Once emoji's get added to status messages at a later time, it could pull the emoji instead of the bubble icon. |
Contributor
Author
|
Now that NRR is pulled, I'm wondering if this will just work? 🤔 @ggazzo |
…4892-wreiske-user-status-bubbles * 'develop' of github.com:RocketChat/Rocket.Chat: (540 commits) [FIX] Show error message if password and confirm password not equal (RocketChat#16247) [FIX] Message quote button inside threads (RocketChat#16925) Fix wrong imported library meteor/tap:i18n lint [IMPROVE] User gets feedback when a message has been starred or unstarred (RocketChat#13860) [FIX] admin can sort users by email in directory view (RocketChat#15796) [FIX] Pinned messages wouldn't collapse (RocketChat#16188) [IMPROVE] Added border to page header. (RocketChat#16792) [FIX] Correct thread messages display in context bar. (RocketChat#16835) [FIX] Public channel cannot be acessed via URL when 'Allow Anonymous Read' is active (RocketChat#16914) Fixed Line break incorrectly being called apostrophe (RocketChat#16918) [IMPROVE] Context menu autofocus (RocketChat#16915) Improve room types usage (RocketChat#16753) [NEW] API `users.deactivateIdle` for mass-disabling of idle users (RocketChat#16849) [NEW] API to logout from other locations (RocketChat#16193) [IMPROVE] Add option to require authentication on user's shield endpoint (RocketChat#16845) [FIX] Custom OAuth Bug (RocketChat#16811) [FIX] Integrations page pagination (RocketChat#16838) reset package-lock to upstream Apply suggestions from code review ...
rodrigok
changed the title
ggazzo
approved these changes
May 8, 2020
Contributor
Author
|
🥳 |
gabriellsh
added a commit
that referenced
this pull request
May 9, 2020
…grations * 'develop' of github.com:RocketChat/Rocket.Chat: [FIX] LDAP login on Enteprise Version (#17508) [FIX] Login Forbidden on servers that had LDAP enabled in the past (#17579) [FIX] Email configs not updating after setting changes (#17578) [FIX] Error during data export for DMs (#17577) Regression: Override via env for string settings not working (#17576) [FIX] Emoji picker search broken (#17570) Add some missing metadata information (#17524) Bump jquery from 3.3.1 to 3.5.0 (#17486) [NEW] Show user's status description by the usernames in messages list (#14892) DPlatform is deprecated and the replacement does not support rocket.chat (#17040) Regression: RegExp callbacks of settings were not being called (#17552) Meteor update to version 1.10.2 (#17533)
ggazzo
added a commit
that referenced
this pull request
May 10, 2020
…/new-threads * 'develop' of github.com:RocketChat/Rocket.Chat: [FIX] Push settings enabled when push gateway is selected (#17582) [FIX] LDAP login on Enteprise Version (#17508) [FIX] Login Forbidden on servers that had LDAP enabled in the past (#17579) [FIX] Email configs not updating after setting changes (#17578) [FIX] Error during data export for DMs (#17577) Regression: Override via env for string settings not working (#17576) [FIX] Emoji picker search broken (#17570) Add some missing metadata information (#17524) Bump jquery from 3.3.1 to 3.5.0 (#17486) [NEW] Show user's status description by the usernames in messages list (#14892) DPlatform is deprecated and the replacement does not support rocket.chat (#17040)
ggazzo
added a commit
that referenced
this pull request
May 11, 2020
* 'develop' of github.com:RocketChat/Rocket.Chat: [FIX] LDAP login on Enteprise Version (#17508) [FIX] Login Forbidden on servers that had LDAP enabled in the past (#17579) [FIX] Email configs not updating after setting changes (#17578) [FIX] Error during data export for DMs (#17577) Regression: Override via env for string settings not working (#17576) [FIX] Emoji picker search broken (#17570) Add some missing metadata information (#17524) Bump jquery from 3.3.1 to 3.5.0 (#17486) [NEW] Show user's status description by the usernames in messages list (#14892) DPlatform is deprecated and the replacement does not support rocket.chat (#17040) Regression: RegExp callbacks of settings were not being called (#17552) Meteor update to version 1.10.2 (#17533) Fix default offline channel name when saving departments. (#17553) [NEW] Screen Lock settings - mobile client (#17523)
ggazzo
added a commit
that referenced
this pull request
May 12, 2020
…ve-get-dom * 'develop' of github.com:RocketChat/Rocket.Chat: [FIX] Push settings enabled when push gateway is selected (#17582) [FIX] LDAP login on Enteprise Version (#17508) [FIX] Login Forbidden on servers that had LDAP enabled in the past (#17579) [FIX] Email configs not updating after setting changes (#17578) [FIX] Error during data export for DMs (#17577) Regression: Override via env for string settings not working (#17576) [FIX] Emoji picker search broken (#17570) Add some missing metadata information (#17524) Bump jquery from 3.3.1 to 3.5.0 (#17486) [NEW] Show user's status description by the usernames in messages list (#14892) DPlatform is deprecated and the replacement does not support rocket.chat (#17040) Regression: RegExp callbacks of settings were not being called (#17552) Meteor update to version 1.10.2 (#17533) Fix default offline channel name when saving departments. (#17553) [NEW] Screen Lock settings - mobile client (#17523)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a work in progress.... I can't seem to get them to be reactive! Maybe @Hudell knows?
The status bubble only shows if the user has a status message. The status text displays when you hover over the status bubble.