A proposed fix for icons with Unicode mirror issue#1582
Closed
fduraibi wants to merge 1 commit intoRocketChat:developfrom
Closed
A proposed fix for icons with Unicode mirror issue#1582fduraibi wants to merge 1 commit intoRocketChat:developfrom
fduraibi wants to merge 1 commit intoRocketChat:developfrom
Conversation
This is a proposed fix to issue RocketChat#1577, so the font does not need to be changed.
Member
|
The best way to fix this.. is to update the /private/fontello.json and re generate the font files using the correct Unicode, so we can use the mirror feature for the icons that really need the mirror, rather than forcing on the CSS. |
Member
|
After you update the JSON file.. go to http://fontello.com/ and drag an drop the file into the screen. Check if the changes have been applied, and download the files. Once downloaded, you have to rename the files accordingly to replace the existing ones. OR Send me the new JSON file and I'll do it :) |
Contributor
Author
|
@engelgabriel Check the font I created in the patch #1594 It includes the fixed json, css and the binary font |
Contributor
Author
|
I will close this one since it is not valid any more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposed fix to issue #1577, so the font does not need to be changed.