Skip to content

Font mirror icons fix#1594

Merged
engelgabriel merged 4 commits intoRocketChat:developfrom
fduraibi:patch-font-mirror
Dec 8, 2015
Merged

Font mirror icons fix#1594
engelgabriel merged 4 commits intoRocketChat:developfrom
fduraibi:patch-font-mirror

Conversation

@fduraibi
Copy link
Contributor

@fduraibi fduraibi commented Dec 7, 2015

Updating the font file to move "spin4" and "sliders" icons to locations with no mirror property

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to remove the font/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, i didn't check that file I simply put it inside the folder. But is it actually needed for the project? I feel it is just to check on the output.

@engelgabriel
Copy link
Member

We should also fix it in a way that the following is no longger requeired:

    /* Overridding the icons Unicode to suit RTL languages
     * from _octicons.less */
    .octicon-chevron-right:before { content: '\f0a4'}
    .icon-angle-right:before { content: '\e914'; }

@fduraibi
Copy link
Contributor Author

fduraibi commented Dec 7, 2015

True, but that one if a different font, isn't it?

I also found the official list of all characters with mirroring property http://www.unicode.org/Public/UCD/latest/ucd/BidiMirroring.txt

@fduraibi
Copy link
Contributor Author

fduraibi commented Dec 7, 2015

I also didn't include the generated svg file thinking it was not used, and now I see that it is in the project folder under private/images. Should I include that also?

@engelgabriel
Copy link
Member

The icon-angle-right is fontello... so we can change and fix it.
Please copy the SVG to the right place.. just in case someone need it.
Leave the octicon for now.. i'll remove it later.
Thanks!

Remove the icons that are not mirrored to regular locations. And moved the icons that need mirroring to mirrored locations. Replaced "octicon-chevron-right" with new set of mirrored icons from fontello
@fduraibi
Copy link
Contributor Author

fduraibi commented Dec 8, 2015

The new commit should take care of all that.

and for the octicon, I added a new one from fontello that similar to its shape icon-right-open-small and its mirror icon-left-open-small to replace it.

@engelgabriel
Copy link
Member

sorry.. can you review the conflicts so I can finally merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments