[IMPROVE] Allow login of non LDAP users when LDAP is enabled#16949
Merged
[IMPROVE] Allow login of non LDAP users when LDAP is enabled#16949
Conversation
rodrigok
changed the title
sampaiodiego
approved these changes
Mar 20, 2020
ggazzo
added a commit
that referenced
this pull request
Mar 21, 2020
…ultiple-users * 'develop' of github.com:RocketChat/Rocket.Chat: (35 commits) Change license version requested (#16956) Synchronize saml roles to local user (#16158) Fix: Padding required in the Facebook Messenger option in Livechat (#16202) Add some missing ES translations (#16120) Adding margin to click to load text (#16210) [FIX] Explicitly set text of confirmation button (#16138) Redirected to home when a room has been deleted instead of getting broken link(blank page) of deleted room (#16227) Fixed translate variable in ArchiveRoom Modal (#16310) [FIX] Display user status along with icon (#16875) [FIX] users.setStatus and user from params (#16128) Update cypress to version 4.0.2 (#16685) [FIX] Text formatted to remain within button even on screen resize (#14136) fix(slack-bridge): messages doesn't send to slack after renaming channel (#16565) [NEW] Route to get updated roles after a date (#16610) [FIX] Removed Reply in DM from livechat rooms (#16957) Update presence package (#16786) [NEW] Enterprise Edition (#16944) Add an index to the name field for omnichannel department (#16953) [FIX] Login with LinkedIn not mapping name and picture correctly (#16955) [IMPROVE] Allow login of non LDAP users when LDAP is enabled (#16949) ...
ggazzo
added a commit
that referenced
this pull request
Mar 21, 2020
…ultiple-users * 'develop' of github.com:RocketChat/Rocket.Chat: (35 commits) Change license version requested (#16956) Synchronize saml roles to local user (#16158) Fix: Padding required in the Facebook Messenger option in Livechat (#16202) Add some missing ES translations (#16120) Adding margin to click to load text (#16210) [FIX] Explicitly set text of confirmation button (#16138) Redirected to home when a room has been deleted instead of getting broken link(blank page) of deleted room (#16227) Fixed translate variable in ArchiveRoom Modal (#16310) [FIX] Display user status along with icon (#16875) [FIX] users.setStatus and user from params (#16128) Update cypress to version 4.0.2 (#16685) [FIX] Text formatted to remain within button even on screen resize (#14136) fix(slack-bridge): messages doesn't send to slack after renaming channel (#16565) [NEW] Route to get updated roles after a date (#16610) [FIX] Removed Reply in DM from livechat rooms (#16957) Update presence package (#16786) [NEW] Enterprise Edition (#16944) Add an index to the name field for omnichannel department (#16953) [FIX] Login with LinkedIn not mapping name and picture correctly (#16955) [IMPROVE] Allow login of non LDAP users when LDAP is enabled (#16949) ...
ggazzo
added a commit
that referenced
this pull request
Mar 21, 2020
…ultiple-users * 'develop' of github.com:RocketChat/Rocket.Chat: (35 commits) Change license version requested (#16956) Synchronize saml roles to local user (#16158) Fix: Padding required in the Facebook Messenger option in Livechat (#16202) Add some missing ES translations (#16120) Adding margin to click to load text (#16210) [FIX] Explicitly set text of confirmation button (#16138) Redirected to home when a room has been deleted instead of getting broken link(blank page) of deleted room (#16227) Fixed translate variable in ArchiveRoom Modal (#16310) [FIX] Display user status along with icon (#16875) [FIX] users.setStatus and user from params (#16128) Update cypress to version 4.0.2 (#16685) [FIX] Text formatted to remain within button even on screen resize (#14136) fix(slack-bridge): messages doesn't send to slack after renaming channel (#16565) [NEW] Route to get updated roles after a date (#16610) [FIX] Removed Reply in DM from livechat rooms (#16957) Update presence package (#16786) [NEW] Enterprise Edition (#16944) Add an index to the name field for omnichannel department (#16953) [FIX] Login with LinkedIn not mapping name and picture correctly (#16955) [IMPROVE] Allow login of non LDAP users when LDAP is enabled (#16949) ...
|
That is a really good improvement for LDAP enabled environments! |
Merged
Closed
@rodrigok @pierre-lehnen-rc @sampaiodiego @ggazzo |
Member
Author
|
@ankar84 what Rocket.Chat version are you using? |
Version 3.1.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, the LDAP Login Fallback isn't necessary anymore to allow system users to login (usual for admin accounts that were created before the LDAP sync). So now the LDAP Fallback is disabled by default meaning that the users' passwords will not be saved in rocket.chat by default anymore.
Closes #6144