Skip to content

[FIX] Remove Reply in DM from Omnichannel rooms#16957

Merged
rodrigok merged 3 commits intoRocketChat:developfrom
ashwaniYDV:livechattabs
Mar 20, 2020
Merged

[FIX] Remove Reply in DM from Omnichannel rooms#16957
rodrigok merged 3 commits intoRocketChat:developfrom
ashwaniYDV:livechattabs

Conversation

@ashwaniYDV
Copy link
Contributor

@ashwaniYDV ashwaniYDV commented Mar 20, 2020 •
edited
Loading

Description:

Reply as DM showing room not found.
11

Fix:

Since the error is not allowed, therefore there should not be reply as DM context tabs
in livechat rooms

@ashwaniYDV
Copy link
Contributor Author

ashwaniYDV commented Mar 20, 2020 •
edited
Loading

hi! @renatobecker
Is this intentional? Please review :)

@renatobecker renatobecker added this to the 3.1.0 milestone Mar 20, 2020
@renatobecker renatobecker changed the title [FIX] Removed Reply in DM from livechat rooms [FIX] Remove Reply in DM from Omnichannel rooms Mar 20, 2020
@rodrigok rodrigok merged commit caf630e into RocketChat:develop Mar 20, 2020
ggazzo added a commit that referenced this pull request Mar 21, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into dm/m…
f7fe0be 
…ultiple-users

* 'develop' of github.com:RocketChat/Rocket.Chat: (35 commits)
  Change license version requested (#16956)
  Synchronize saml roles to local user (#16158)
  Fix: Padding required in the Facebook Messenger option in Livechat (#16202)
  Add some missing ES translations (#16120)
  Adding margin to click to load text (#16210)
  [FIX] Explicitly set text of confirmation button (#16138)
  Redirected to home when a room has been deleted instead of getting broken link(blank page) of deleted room (#16227)
  Fixed translate variable in ArchiveRoom Modal (#16310)
  [FIX] Display user status along with icon (#16875)
  [FIX] users.setStatus and user from params (#16128)
  Update cypress to version 4.0.2 (#16685)
  [FIX] Text formatted to remain within button even on screen resize  (#14136)
  fix(slack-bridge): messages doesn't send to slack after renaming channel (#16565)
  [NEW] Route to get updated roles after a date (#16610)
  [FIX] Removed Reply in DM from livechat rooms (#16957)
  Update presence package (#16786)
  [NEW] Enterprise Edition (#16944)
  Add an index to the name field for omnichannel department (#16953)
  [FIX] Login with LinkedIn not mapping name and picture correctly (#16955)
  [IMPROVE] Allow login of non LDAP users when LDAP is enabled (#16949)
  ...
ggazzo added a commit that referenced this pull request Mar 21, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into dm/m…
82439cf 
…ultiple-users

* 'develop' of github.com:RocketChat/Rocket.Chat: (35 commits)
  Change license version requested (#16956)
  Synchronize saml roles to local user (#16158)
  Fix: Padding required in the Facebook Messenger option in Livechat (#16202)
  Add some missing ES translations (#16120)
  Adding margin to click to load text (#16210)
  [FIX] Explicitly set text of confirmation button (#16138)
  Redirected to home when a room has been deleted instead of getting broken link(blank page) of deleted room (#16227)
  Fixed translate variable in ArchiveRoom Modal (#16310)
  [FIX] Display user status along with icon (#16875)
  [FIX] users.setStatus and user from params (#16128)
  Update cypress to version 4.0.2 (#16685)
  [FIX] Text formatted to remain within button even on screen resize  (#14136)
  fix(slack-bridge): messages doesn't send to slack after renaming channel (#16565)
  [NEW] Route to get updated roles after a date (#16610)
  [FIX] Removed Reply in DM from livechat rooms (#16957)
  Update presence package (#16786)
  [NEW] Enterprise Edition (#16944)
  Add an index to the name field for omnichannel department (#16953)
  [FIX] Login with LinkedIn not mapping name and picture correctly (#16955)
  [IMPROVE] Allow login of non LDAP users when LDAP is enabled (#16949)
  ...
ggazzo added a commit that referenced this pull request Mar 21, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into dm/m…
f4a71e8 
…ultiple-users

* 'develop' of github.com:RocketChat/Rocket.Chat: (35 commits)
  Change license version requested (#16956)
  Synchronize saml roles to local user (#16158)
  Fix: Padding required in the Facebook Messenger option in Livechat (#16202)
  Add some missing ES translations (#16120)
  Adding margin to click to load text (#16210)
  [FIX] Explicitly set text of confirmation button (#16138)
  Redirected to home when a room has been deleted instead of getting broken link(blank page) of deleted room (#16227)
  Fixed translate variable in ArchiveRoom Modal (#16310)
  [FIX] Display user status along with icon (#16875)
  [FIX] users.setStatus and user from params (#16128)
  Update cypress to version 4.0.2 (#16685)
  [FIX] Text formatted to remain within button even on screen resize  (#14136)
  fix(slack-bridge): messages doesn't send to slack after renaming channel (#16565)
  [NEW] Route to get updated roles after a date (#16610)
  [FIX] Removed Reply in DM from livechat rooms (#16957)
  Update presence package (#16786)
  [NEW] Enterprise Edition (#16944)
  Add an index to the name field for omnichannel department (#16953)
  [FIX] Login with LinkedIn not mapping name and picture correctly (#16955)
  [IMPROVE] Allow login of non LDAP users when LDAP is enabled (#16949)
  ...
@ashwaniYDV ashwaniYDV deleted the livechattabs branch March 30, 2020 14:07
@sampaiodiego sampaiodiego mentioned this pull request Apr 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@renatobecker renatobecker renatobecker approved these changes

Assignees

No one assigned

Labels

type: bug

Projects

None yet

Milestone

3.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ashwaniYDV @renatobecker @rodrigok

Comments