Conversation
…t-forwarding-callback
sampaiodiego
requested changes
Mar 21, 2020
| } | ||
|
|
||
| LivechatRooms.updateDepartmentAncestorsById(room._id, ancestors); | ||
| return LivechatRooms.findOneById(rid); |
Member
There was a problem hiding this comment.
callbacks should return the same input param, because the return will be passed to the next callback.
…t-forwarding-callback
sampaiodiego
force-pushed
the
omnichannel/add-new-omnichannel-department-forwarding-callback
branch
from
685557b to
22b0aa8
Compare
sampaiodiego
approved these changes
Mar 21, 2020
rodrigok
deleted the
omnichannel/add-new-omnichannel-department-forwarding-callback
branch
rodrigok
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #16779
Currently, the ancestral departments are stored in the room only when the room is created, so when an Omnichannel room is forwarded from a department to another, we need to update the ancestral departments of the room based on the new department.