Skip to content

Regression: Can't login with 2FA over REST API when 2FA via Email is enabled#17128

Merged
sampaiodiego merged 1 commit intoRocketChat:developfrom
djorkaeffalexandre:fix.login-rest
Apr 1, 2020
Merged

Regression: Can't login with 2FA over REST API when 2FA via Email is enabled#17128
sampaiodiego merged 1 commit intoRocketChat:developfrom
djorkaeffalexandre:fix.login-rest

Conversation

@djorkaeffalexandre
Copy link
Contributor

Fixes an error when using a POST on /login with 2FA activated, this needs to return the details of the error to be used by 2FA.

@djorkaeffalexandre djorkaeffalexandre changed the title [FIX] Return error details on login REST [REGRESSION] Return error details on login REST Apr 1, 2020
@djorkaeffalexandre djorkaeffalexandre changed the title [REGRESSION] Return error details on login REST Regression: Can't login with 2FA over REST API when 2FA via Email is enabled Apr 1, 2020
@rodrigok rodrigok added this to the 3.1.0 milestone Apr 1, 2020
@sampaiodiego sampaiodiego merged commit 8f2026a into RocketChat:develop Apr 1, 2020
gabriellsh added a commit that referenced this pull request Apr 2, 2020
…default-favorite-channels

* 'develop' of github.com:RocketChat/Rocket.Chat: (304 commits)
  [FIX] Omnichannel endpoint `inquiries.getOne` returning only queued inquiries (#17132)
  Fix design review (#17133)
  Regression: Direct message creation by REST (#17109)
  Regression: Can't login with 2FA over REST API when 2FA via Email is enabled (#17128)
  Regression: Fix engagement dashboard urls, fixing Flowrouter imports (#17127)
  Regression: IE11 Support (#17125)
  [FIX] Federation delete room event not being dispatched (#16861)
  [FIX] Federation Event ROOM_ADD_USER not being dispatched (#16878)
  New Troubleshoot section for disabling features (#17114)
  Regression: Wrong size of Directory search/sort icons and Sort Channels menu not showing on production build (#17118)
  [NEW] Discussions: Inherit the public status of parent channel (#17070)
  Regression: fix fuselage import, remove directory css (#17116)
  [IMPROVE] Apps Engine: Reduce some stream calls and remove a find user from the app's status changes (#17115)
  Regression: Remove old and closed Omnichannel inquiries (#17113)
  [FIX] Member's list only filtering users already on screen (#17110)
  Single codebase announcement (#17081)
  [NEW] Directory page refactored, new user's bio field (#17043)
  [NEW] Sort List, View Mode and Group by revamp (#17103)
  Regression: Files were been deleted when deleting users as last members of private rooms (#17111)
  Regression: Block users was not possible for 1:1 DMs (#17105)
  ...
ggazzo added a commit that referenced this pull request Apr 3, 2020
…per-call-meteor-methods-over-rest

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Can't login with 2FA over REST API when 2FA via Email is enabled (#17128)
  Regression: Fix engagement dashboard urls, fixing Flowrouter imports (#17127)
  Regression: IE11 Support (#17125)
  [FIX] Federation delete room event not being dispatched (#16861)
  [FIX] Federation Event ROOM_ADD_USER not being dispatched (#16878)
  New Troubleshoot section for disabling features (#17114)
  Regression: Wrong size of Directory search/sort icons and Sort Channels menu not showing on production build (#17118)
  [NEW] Discussions: Inherit the public status of parent channel (#17070)
  Regression: fix fuselage import, remove directory css (#17116)
  [IMPROVE] Apps Engine: Reduce some stream calls and remove a find user from the app's status changes (#17115)
  Regression: Remove old and closed Omnichannel inquiries (#17113)
  [FIX] Member's list only filtering users already on screen (#17110)
  Single codebase announcement (#17081)
  [NEW] Directory page refactored, new user's bio field (#17043)
  [NEW] Sort List, View Mode and Group by revamp (#17103)
  Regression: Files were been deleted when deleting users as last members of private rooms (#17111)
  Regression: Block users was not possible for 1:1 DMs (#17105)
  Regression: Collapsible elements didn't respect attachment parameter. (#16994)
  [FIX] Apps Engine notifyRoom sending notification to wrong users (#17093)
@sampaiodiego sampaiodiego mentioned this pull request Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments