[FIX] Add missing custom fields to apps' users converter#21176
Merged
casalsgh merged 8 commits intoRocketChat:developfrom Sep 15, 2021
Merged
[FIX] Add missing custom fields to apps' users converter#21176casalsgh merged 8 commits intoRocketChat:developfrom
casalsgh merged 8 commits intoRocketChat:developfrom
Conversation
|
These fields have been lacking for a long time 🥺 |
JargeZ
approved these changes
Apr 5, 2021
JargeZ
left a comment
JargeZ
left a comment
There was a problem hiding this comment.
I tested this as a local patch. Works properly.
Any thought about accepting this PR?
|
Hi! This looks like it would fix the issue I've been encountering where an application cannot fetch a custom field for a user and also what the forum members at https://forums.rocket.chat/t/accessing-senders-custom-fields-inside-islashcommands-executor/9715/5 encountered. Is there any progress to getting this merged? Thanks |
Contributor
Author
|
@d-gubert hi, could u help me to merge this? |
d-gubert
approved these changes
Sep 6, 2021
gabriellsh
added a commit
that referenced
this pull request
Sep 16, 2021
…/seats-cap * 'develop' of github.com:RocketChat/Rocket.Chat: [IMPROVE] General room reappears after being deleted (#22957) [NEW][APPS] Get livechat's room transcript via bridge method (#22985) Regression: `renderEmoji` helper referred as a template (#23212) Chore: Convert VerticalBar component to typescript (#22542) Add missing custom fields to apps' users converter (#21176) Regression: Fix view logs admin screen (#23194) [BREAK] Remove deprecated endpoints (#23162)
gabriellsh
added a commit
that referenced
this pull request
Sep 17, 2021
…to feat/seats-cap-banners * 'feat/seats-cap' of github.com:RocketChat/Rocket.Chat: [NEW] Prevent users from accidentally deactivating an enterprise license by adding more users than the license allows. (#23050) [IMPROVE] Ensure Seats-cap design and UI are the same (#23222) [NEW] Remove license downgrade if exceeding seats cap (#23220) [IMPROVE] Throw error if no appId is provided to useUIKitHandleAction (#23221) [IMPROVE] General room reappears after being deleted (#22957) [NEW][APPS] Get livechat's room transcript via bridge method (#22985) Regression: `renderEmoji` helper referred as a template (#23212) Chore: Convert VerticalBar component to typescript (#22542) Add missing custom fields to apps' users converter (#21176) Regression: Fix view logs admin screen (#23194) [BREAK] Remove deprecated endpoints (#23162)
gabriellsh
added a commit
that referenced
this pull request
Sep 17, 2021
…to feat/seats-cap-stats * 'feat/seats-cap' of github.com:RocketChat/Rocket.Chat: [NEW] Prevent users from accidentally deactivating an enterprise license by adding more users than the license allows. (#23050) [IMPROVE] Ensure Seats-cap design and UI are the same (#23222) [NEW] Remove license downgrade if exceeding seats cap (#23220) [IMPROVE] Throw error if no appId is provided to useUIKitHandleAction (#23221) [IMPROVE] General room reappears after being deleted (#22957) [NEW][APPS] Get livechat's room transcript via bridge method (#22985) Regression: `renderEmoji` helper referred as a template (#23212) Chore: Convert VerticalBar component to typescript (#22542) Add missing custom fields to apps' users converter (#21176) Regression: Fix view logs admin screen (#23194) [BREAK] Remove deprecated endpoints (#23162)
gabriellsh
added a commit
that referenced
this pull request
Sep 21, 2021
…to fix/bannerParser * 'feat/seats-cap' of github.com:RocketChat/Rocket.Chat: (91 commits) [NEW] stats on seats request (#23225) [NEW] Prevent users from accidentally deactivating an enterprise license by adding more users than the license allows. (#23050) [IMPROVE] Ensure Seats-cap design and UI are the same (#23222) [NEW] Remove license downgrade if exceeding seats cap (#23220) [IMPROVE] Throw error if no appId is provided to useUIKitHandleAction (#23221) [IMPROVE] General room reappears after being deleted (#22957) [NEW][APPS] Get livechat's room transcript via bridge method (#22985) Regression: `renderEmoji` helper referred as a template (#23212) Chore: Convert VerticalBar component to typescript (#22542) Add missing custom fields to apps' users converter (#21176) Regression: Fix view logs admin screen (#23194) [BREAK] Remove deprecated endpoints (#23162) [NEW] Seats Cap: Request seats link (#23151) Regression: View Logs administration page crashing (#23205) Chore: Move client helpers (#23178) Chore: Change Ubuntu version to 20.04 on all GitHub Actions (#23200) Regression: Properly trickle-down state from UsersPage to UsersTable (#23196) [IMPROVE] Add missing pt-BR translations, fix typos and unify language (#23176) [NEW] Seats Card (#23077) [FIX] User list not being updated after creation/deletion of user (#23032) ...
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Add missing
customFieldsmapping for the app users converter.Issue(s)
Steps to test or reproduce
Further comments