[FIX] Room names were not displayed correctly in the admin's RoomAutoComplete 'users in roles'#21640
Closed
Jeanstaquet wants to merge 18 commits intoRocketChat:developfrom
Jeanstaquet:FixRoomAutoComplete
Closed
[FIX] Room names were not displayed correctly in the admin's RoomAutoComplete 'users in roles'#21640Jeanstaquet wants to merge 18 commits intoRocketChat:developfrom Jeanstaquet:FixRoomAutoComplete
Jeanstaquet wants to merge 18 commits intoRocketChat:developfrom
Jeanstaquet:FixRoomAutoComplete
Conversation
updating the code
updating the code
updating the fork
update main branch
updating the branch
Update fork
Upating the fork
Updating fork
Updating fork
Contributor
Author
|
Hello @dougfabris can you review it please ? |
|
|
Member
|
Hi there, thanks for the contribution! 🚀 💯 Closing this PR because it's stale now and it will be fixed here: #32320 Questions? Help needed? Feature Requests?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
I changed the field so that the rooms show the room name instead of the rid. I also corrected the placeholder of the input field which was not correct
2021-04-19.03-31-47.mp4
Issue(s)
Fixes #21639
Steps to test or reproduce
Further comments