[FIX] Canned response endpoint isn't filtering by text#22207
Merged
tiagoevanp merged 1 commit intoimprove/canned-responsefrom Jun 1, 2021
Merged
[FIX] Canned response endpoint isn't filtering by text#22207tiagoevanp merged 1 commit intoimprove/canned-responsefrom
tiagoevanp merged 1 commit intoimprove/canned-responsefrom
Conversation
tiagoevanp
approved these changes
Jun 1, 2021
tiagoevanp
changed the title
KevLehman
pushed a commit
that referenced
this pull request
Jul 19, 2021
#22190) * no results components to table with no data * [IMPROVE][Enterprise] Create and Update CannedResponse API endpoints (#22151) * createdBy query fix * fix the canned-responses filter (#22207) * [NEW] New components TextEditor and MarkdownTextEditor (#22173) * Include Insert_Placeholder key * change emojiPicker z-index * create TextEditor component * create MarkdownTextEditor component * update fuselage dev version * update fuselage and react-types version * finish MardownTextEditorComponent * update fuselage package * [NEW][ENTERPRISE] Canned responses Overview Page (#22623) * [NEW] Empty page for Canned Responses Table * FIX LGTM * stop showing the empty page on loading Co-authored-by: Rafael Ferreira <rafael.ferreira@rocket.chat> Co-authored-by: Tiago Evangelista Pinto <tiago.evangelista@rocket.chat> Co-authored-by: Martin <martin.schoeler@rocket.chat>
KevLehman
added a commit
that referenced
this pull request
Jul 20, 2021
…extual Bar (#22715) * [IMPROVE][Enterprise] Create and Update CannedResponse API endpoints (#22151) * createdBy query fix * fix the canned-responses filter (#22207) * fix Thread tslint error * create .d.ts file to VerticalBar component * rewrite Canned Responses contextual-bar components * update fuselage version * types for room.js * create hooks for canned options and departments * adjustments in cannedResponse contextual-bar * adjustments in cannedResponse modal * adjust in endpoints types * adjust canned list * adjust omnichanel canned response type definition * add some new translations * remove old stuff of cannedResponses * [NEW] New components TextEditor and MarkdownTextEditor (#22173) * Include Insert_Placeholder key * change emojiPicker z-index * create TextEditor component * create MarkdownTextEditor component * update fuselage dev version * update fuselage and react-types version * finish MardownTextEditorComponent * update fuselage package * modal with MarkdownTextEditor component * reload component when edited * fix form handle error * add key prop * create preview for MarkdownTextEditor * remove canned-response contextual-bar from departments settings * Use permissions instead of roles to check for canned responses * Chore: added pagination to search msg endpoint (#22632) * added pagination to search endpoint * readded tests * change livechat_enabled default value to true (#22697) Co-authored-by: Leonardo Ostjen Couto <leonardoostjen@gmail.com> * Add New and Edit with Data * Use permissions instead of roles to check for canned responses * New and edit pages * Lint and removal of unused files * fix lint * FIX departments not working * remove duplicate i18n key * Misc improvements to canned responses endpoints * Ts fixes * more ts fixes * use permission instead role * Fix shortcut validation * Fix shortcut validation * Fix department & validation issues * fix Co-authored-by: Rafael Ferreira <rafaelblink@gmail.com> Co-authored-by: Rafael Ferreira <rafael.ferreira@rocket.chat> Co-authored-by: Tiago Evangelista Pinto <tiago.evangelista@rocket.chat> Co-authored-by: Kevin Aleman <kevin.aleman@rocket.chat> Co-authored-by: Leonardo Ostjen Couto <leonardoostjen@gmail.com>
KevLehman
pushed a commit
that referenced
this pull request
Jul 20, 2021
#22190) * no results components to table with no data * [IMPROVE][Enterprise] Create and Update CannedResponse API endpoints (#22151) * createdBy query fix * fix the canned-responses filter (#22207) * [NEW] New components TextEditor and MarkdownTextEditor (#22173) * Include Insert_Placeholder key * change emojiPicker z-index * create TextEditor component * create MarkdownTextEditor component * update fuselage dev version * update fuselage and react-types version * finish MardownTextEditorComponent * update fuselage package * [NEW][ENTERPRISE] Canned responses Overview Page (#22623) * [NEW] Empty page for Canned Responses Table * FIX LGTM * stop showing the empty page on loading Co-authored-by: Rafael Ferreira <rafael.ferreira@rocket.chat> Co-authored-by: Tiago Evangelista Pinto <tiago.evangelista@rocket.chat> Co-authored-by: Martin <martin.schoeler@rocket.chat>
KevLehman
added a commit
that referenced
this pull request
Jul 20, 2021
…extual Bar (#22715) * [IMPROVE][Enterprise] Create and Update CannedResponse API endpoints (#22151) * createdBy query fix * fix the canned-responses filter (#22207) * fix Thread tslint error * create .d.ts file to VerticalBar component * rewrite Canned Responses contextual-bar components * update fuselage version * types for room.js * create hooks for canned options and departments * adjustments in cannedResponse contextual-bar * adjustments in cannedResponse modal * adjust in endpoints types * adjust canned list * adjust omnichanel canned response type definition * add some new translations * remove old stuff of cannedResponses * [NEW] New components TextEditor and MarkdownTextEditor (#22173) * Include Insert_Placeholder key * change emojiPicker z-index * create TextEditor component * create MarkdownTextEditor component * update fuselage dev version * update fuselage and react-types version * finish MardownTextEditorComponent * update fuselage package * modal with MarkdownTextEditor component * reload component when edited * fix form handle error * add key prop * create preview for MarkdownTextEditor * remove canned-response contextual-bar from departments settings * Use permissions instead of roles to check for canned responses * Chore: added pagination to search msg endpoint (#22632) * added pagination to search endpoint * readded tests * change livechat_enabled default value to true (#22697) Co-authored-by: Leonardo Ostjen Couto <leonardoostjen@gmail.com> * Add New and Edit with Data * Use permissions instead of roles to check for canned responses * New and edit pages * Lint and removal of unused files * fix lint * FIX departments not working * remove duplicate i18n key * Misc improvements to canned responses endpoints * Ts fixes * more ts fixes * use permission instead role * Fix shortcut validation * Fix shortcut validation * Fix department & validation issues * fix Co-authored-by: Rafael Ferreira <rafaelblink@gmail.com> Co-authored-by: Rafael Ferreira <rafael.ferreira@rocket.chat> Co-authored-by: Tiago Evangelista Pinto <tiago.evangelista@rocket.chat> Co-authored-by: Kevin Aleman <kevin.aleman@rocket.chat> Co-authored-by: Leonardo Ostjen Couto <leonardoostjen@gmail.com>
KevLehman
added a commit
that referenced
this pull request
Jul 21, 2021
* [IMPROVE][Enterprise] Create and Update CannedResponse API endpoints (#22151) * [NEW] New components TextEditor and MarkdownTextEditor (#22173) * Include Insert_Placeholder key * change emojiPicker z-index * create TextEditor component * create MarkdownTextEditor component * update fuselage dev version * update fuselage and react-types version * finish MardownTextEditorComponent * update fuselage package * [NEW][ENTERPRISE] Canned responses Overview Page (#22623) * [IMPROVE] No results component for canned responses table with no data (#22190) * no results components to table with no data * [IMPROVE][Enterprise] Create and Update CannedResponse API endpoints (#22151) * createdBy query fix * fix the canned-responses filter (#22207) * [NEW] New components TextEditor and MarkdownTextEditor (#22173) * Include Insert_Placeholder key * change emojiPicker z-index * create TextEditor component * create MarkdownTextEditor component * update fuselage dev version * update fuselage and react-types version * finish MardownTextEditorComponent * update fuselage package * [NEW][ENTERPRISE] Canned responses Overview Page (#22623) * [NEW] Empty page for Canned Responses Table * FIX LGTM * stop showing the empty page on loading Co-authored-by: Rafael Ferreira <rafael.ferreira@rocket.chat> Co-authored-by: Tiago Evangelista Pinto <tiago.evangelista@rocket.chat> Co-authored-by: Martin <martin.schoeler@rocket.chat> * [NEW] NEW and EDIT pages for canned responses + Canned Responses Contextual Bar (#22715) * [IMPROVE][Enterprise] Create and Update CannedResponse API endpoints (#22151) * createdBy query fix * fix the canned-responses filter (#22207) * fix Thread tslint error * create .d.ts file to VerticalBar component * rewrite Canned Responses contextual-bar components * update fuselage version * types for room.js * create hooks for canned options and departments * adjustments in cannedResponse contextual-bar * adjustments in cannedResponse modal * adjust in endpoints types * adjust canned list * adjust omnichanel canned response type definition * add some new translations * remove old stuff of cannedResponses * [NEW] New components TextEditor and MarkdownTextEditor (#22173) * Include Insert_Placeholder key * change emojiPicker z-index * create TextEditor component * create MarkdownTextEditor component * update fuselage dev version * update fuselage and react-types version * finish MardownTextEditorComponent * update fuselage package * modal with MarkdownTextEditor component * reload component when edited * fix form handle error * add key prop * create preview for MarkdownTextEditor * remove canned-response contextual-bar from departments settings * Use permissions instead of roles to check for canned responses * Chore: added pagination to search msg endpoint (#22632) * added pagination to search endpoint * readded tests * change livechat_enabled default value to true (#22697) Co-authored-by: Leonardo Ostjen Couto <leonardoostjen@gmail.com> * Add New and Edit with Data * Use permissions instead of roles to check for canned responses * New and edit pages * Lint and removal of unused files * fix lint * FIX departments not working * remove duplicate i18n key * Misc improvements to canned responses endpoints * Ts fixes * more ts fixes * use permission instead role * Fix shortcut validation * Fix shortcut validation * Fix department & validation issues * fix Co-authored-by: Rafael Ferreira <rafaelblink@gmail.com> Co-authored-by: Rafael Ferreira <rafael.ferreira@rocket.chat> Co-authored-by: Tiago Evangelista Pinto <tiago.evangelista@rocket.chat> Co-authored-by: Kevin Aleman <kevin.aleman@rocket.chat> Co-authored-by: Leonardo Ostjen Couto <leonardoostjen@gmail.com> Co-authored-by: Rafael Ferreira <rafaelblink@gmail.com> Co-authored-by: Tiago Evangelista Pinto <tiago.evangelista@rocket.chat> Co-authored-by: Rafael Ferreira <rafael.ferreira@rocket.chat> Co-authored-by: Kevin Aleman <kevin.aleman@rocket.chat> Co-authored-by: Leonardo Ostjen Couto <leonardoostjen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments