Skip to content

[IMPROVE] Canned responses#22703

Merged
KevLehman merged 6 commits intodevelopfrom
improve/canned-response
Jul 21, 2021
Merged

[IMPROVE] Canned responses#22703
KevLehman merged 6 commits intodevelopfrom
improve/canned-response

Conversation

@MartinSchoeler
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@KevLehman KevLehman changed the title Improve/canned response [IMPROVE] Canned responses improvements Jul 19, 2021
@KevLehman KevLehman marked this pull request as ready for review July 19, 2021 20:51
rafaelblink and others added 5 commits July 20, 2021 18:24
* Include Insert_Placeholder key

* change emojiPicker z-index

* create TextEditor component

* create MarkdownTextEditor component

* update fuselage dev version

* update fuselage and react-types version

* finish MardownTextEditorComponent

* update fuselage package
#22190)

* no results components to table with no data

* [IMPROVE][Enterprise] Create and Update CannedResponse API endpoints (#22151)

* createdBy query fix

* fix the canned-responses filter (#22207)

* [NEW] New components TextEditor and MarkdownTextEditor (#22173)

* Include Insert_Placeholder key

* change emojiPicker z-index

* create TextEditor component

* create MarkdownTextEditor component

* update fuselage dev version

* update fuselage and react-types version

* finish MardownTextEditorComponent

* update fuselage package

* [NEW][ENTERPRISE] Canned responses Overview Page (#22623)

* [NEW] Empty page for Canned Responses Table

* FIX LGTM

* stop showing the empty page on loading

Co-authored-by: Rafael Ferreira <rafael.ferreira@rocket.chat>
Co-authored-by: Tiago Evangelista Pinto <tiago.evangelista@rocket.chat>
Co-authored-by: Martin <martin.schoeler@rocket.chat>
…extual Bar (#22715)

* [IMPROVE][Enterprise] Create and Update CannedResponse API endpoints (#22151)

* createdBy query fix

* fix the canned-responses filter (#22207)

* fix Thread tslint error

* create .d.ts file to VerticalBar component

* rewrite Canned Responses contextual-bar components

* update fuselage version

* types for room.js

* create hooks for canned options and departments

* adjustments in cannedResponse contextual-bar

* adjustments in cannedResponse modal

* adjust in endpoints types

* adjust canned list

* adjust omnichanel canned response type definition

* add some new translations

* remove old stuff of cannedResponses

* [NEW] New components TextEditor and MarkdownTextEditor (#22173)

* Include Insert_Placeholder key

* change emojiPicker z-index

* create TextEditor component

* create MarkdownTextEditor component

* update fuselage dev version

* update fuselage and react-types version

* finish MardownTextEditorComponent

* update fuselage package

* modal with MarkdownTextEditor component

* reload component when edited

* fix form handle error

* add key prop

* create preview for MarkdownTextEditor

* remove canned-response contextual-bar from departments settings

* Use permissions instead of roles to check for canned responses

* Chore: added pagination to search msg endpoint (#22632)

* added pagination to search endpoint

* readded tests

* change livechat_enabled default value to true (#22697)

Co-authored-by: Leonardo Ostjen Couto <leonardoostjen@gmail.com>

* Add New and Edit with Data

* Use permissions instead of roles to check for canned responses

* New and edit pages

* Lint and removal of unused files

* fix lint

* FIX departments not working

* remove duplicate i18n key

* Misc improvements to canned responses endpoints

* Ts fixes

* more ts fixes

* use permission instead role

* Fix shortcut validation

* Fix shortcut validation

* Fix department & validation issues

* fix

Co-authored-by: Rafael Ferreira <rafaelblink@gmail.com>
Co-authored-by: Rafael Ferreira <rafael.ferreira@rocket.chat>
Co-authored-by: Tiago Evangelista Pinto <tiago.evangelista@rocket.chat>
Co-authored-by: Kevin Aleman <kevin.aleman@rocket.chat>
Co-authored-by: Leonardo Ostjen Couto <leonardoostjen@gmail.com>
@KevLehman KevLehman force-pushed the improve/canned-response branch from 3ac3317 to 152db5c Compare July 20, 2021 23:27
@KevLehman KevLehman changed the title [IMPROVE] Canned responses improvements [IMPROVE] Canned responses Jul 21, 2021
@KevLehman KevLehman merged commit fe696e9 into develop Jul 21, 2021
@KevLehman KevLehman deleted the improve/canned-response branch July 21, 2021 00:34
@ggazzo ggazzo mentioned this pull request Jul 31, 2021
@homberger
Copy link

Is this ENTERPRISE only?

export const createSettings = () => {
settings.addGroup('Canned Responses', function() {
this.section('Canned Responses', function() {
settings.addGroup('Canned_Responses', function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ggazzo , this is the line that has introduced the duplication.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which duplication? 👀

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one we're fixing in #23056

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhh, noticed it 😬 got it.

@sampaiodiego sampaiodiego mentioned this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Comments