Skip to content

[FIX] Remove doubled "Canned Responses" strings#23056

Merged
tassoevan merged 11 commits intodevelopfrom
fix/double-cr-setting
Sep 23, 2021
Merged

[FIX] Remove doubled "Canned Responses" strings#23056
tassoevan merged 11 commits intodevelopfrom
fix/double-cr-setting

Conversation

@matheusbsilva137
Copy link
Contributor

@matheusbsilva137 matheusbsilva137 commented Aug 27, 2021

Proposed changes (including videos or screenshots)

Issue(s)

Task - ClickUp

Steps to test or reproduce

Go to Administration and search for 'Canned Responses'. Only one setting (menu) should be displayed in the sidebar.

Further comments

ggazzo
ggazzo previously requested changes Aug 30, 2021
Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we check and mention where this duplication was introduced? and btw I think we have some bad translations "Canned Responses" instead "Canned_Responses", could you use this issue and fix together?

@matheusbsilva137
Copy link
Contributor Author

matheusbsilva137 commented Aug 30, 2021

Could we check and mention where this duplication was introduced? and btw I think we have some bad translations "Canned Responses" instead "Canned_Responses", could you use this issue and fix together?

I've just updated all the "Canned Responses" keys to "Canned_Responses" (keeping the best translation for each language).
This duplication has been introduced in #22703 (in the ee/app/canned-responses/server/settings.js file changes).

Copy link
Member

@KevLehman KevLehman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this :) (there's a conflict on the migration btw)

tassoevan
tassoevan previously approved these changes Sep 16, 2021
@matheusbsilva137 matheusbsilva137 changed the title [FIX] Remove doubled canned response setting [FIX] Remove doubled "Canned Responses" strings Sep 23, 2021
@tassoevan tassoevan merged commit fed2443 into develop Sep 23, 2021
@tassoevan tassoevan deleted the fix/double-cr-setting branch September 23, 2021 19:09
@sampaiodiego sampaiodiego mentioned this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments