Skip to content

Comments

[FIX] Missing visual validation and users selection field on creating team modal#22332

Closed
dougfabris wants to merge 8 commits intodevelopfrom
fix/create-team-modal
Closed

[FIX] Missing visual validation and users selection field on creating team modal#22332
dougfabris wants to merge 8 commits intodevelopfrom
fix/create-team-modal

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented Jun 12, 2021

Proposed changes (including videos or screenshots)

  • Added visual validation if the team's name is missing:
    image

  • Fix: add members breaking when searching users

image

Additional Improvements:

  • Brand new UserAutoCompleteMultiple.tsx mixed with UsersInput.tsx . I realized they are very similar components so I mixed them into a new unique component, now if we want to handle the users by id we can pass simply a prop handleById to him and voilà

Issue(s)

Steps to test or reproduce

Further comments

@dougfabris dougfabris requested a review from a team June 12, 2021 20:17
@CLAassistant
Copy link

CLAassistant commented Dec 17, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ tassoevan
❌ dougfabris


dougfabris seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dougfabris
Copy link
Member Author

Closing this one in favor of #24529

@dougfabris dougfabris closed this Feb 19, 2022
@dougfabris dougfabris deleted the fix/create-team-modal branch March 29, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants