[FIX] Missing visual validation and users selection field on creating team modal#22332
Closed
dougfabris wants to merge 8 commits intodevelopfrom
Closed
[FIX] Missing visual validation and users selection field on creating team modal#22332dougfabris wants to merge 8 commits intodevelopfrom
dougfabris wants to merge 8 commits intodevelopfrom
Conversation
tassoevan
requested changes
Jun 17, 2021
tassoevan
requested changes
Jun 18, 2021
|
dougfabris seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Member
Author
|
Closing this one in favor of #24529 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Added visual validation if the team's name is missing:

Fix: add members breaking when searching users
Additional Improvements:
UserAutoCompleteMultiple.tsxmixed withUsersInput.tsx. I realized they are very similar components so I mixed them into a new unique component, now if we want to handle the users by id we can pass simply a prophandleByIdto him and voilàIssue(s)
Steps to test or reproduce
Further comments