[IMPROVE] Replace AutoComplete in UserAutoComplete & UserAutoCompleteMultiple components#24529
Merged
[IMPROVE] Replace AutoComplete in UserAutoComplete & UserAutoCompleteMultiple components#24529
Conversation
dougfabris
changed the title
dougfabris
previously approved these changes
Feb 19, 2022
Member
There was a problem hiding this comment.
@juliajforesti fantastic job here, thanks a lot! I would suggest you wait for the PR you did to convert the MultiSelect to ts and already convert UserAutoComplete and UserAutoCompleteMultiple to ts as well, IMO it's going to prevent possible hidden errors in components that use these autocompletes.
…ove/MultiSelect-AutoComplete
tassoevan
approved these changes
Feb 21, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR replaces a deprecated fuselage's component
AutoCompletein favor ofSelectandMultiSelectwhich fixes some of UX/UI issues in selecting usersbefore
after
Issue(s)
Steps to test or reproduce
Further comments