[FIX] users registered via third party apps bypass custom required fields#22396
Merged
[FIX] users registered via third party apps bypass custom required fields#22396
Conversation
gabriellsh
requested changes
Jun 25, 2021
Member
gabriellsh
left a comment
gabriellsh
left a comment
There was a problem hiding this comment.
Trying to register a new user is throwing a custom fields error instead of redirecting to username selection, but It's no longer possible to fill the custom fields since they were moved to the username selection screen.
The user is created normaly though, and loging with email redirects correctly to the username selection.
gabrieleiro
force-pushed
the
fix/oauth-custom-fields
branch
from
4f30f0e to
17b47b0
Compare
gabriellsh
approved these changes
Jul 29, 2021
gabriellsh
added a commit
that referenced
this pull request
Aug 10, 2021
* 'develop' of github.com:RocketChat/Rocket.Chat: [FIX] Manually approve new users is not applied to SAML users (#22823) [FIX] applyChatRestictions callback not working for community version (#22839) [FIX] Message update not working in some cases (#22856) [FIX] Broken download link on uploaded files (#22848) [FIX] User is still asked for 2FA confirmation even if 2FA is globally deactivated. (#22801) [FIX] Registration not possible with TOTP and email verification (#22778) [FIX] users registered via third party apps bypass custom required fields (#22396) [FIX] "Click to Join" button is not working if there are no muted users in the room (#22871) [BREAK][ENTERPRISE] CSV file downloaded in the Engagement Dashboard's New Users section contains undefined data (#22862) Fix Local time conversion in the Users By Time of the Day chart (#22836)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
moves the custom fields from the initial registration form to the "pick a username" screen so that everyone is forced to fill the custom required fields
Issue(s)
Closes #21960
Steps to test or reproduce
Further comments