[FIX] Broken download link on uploaded files#22848
Merged
Conversation
sampaiodiego
requested changes
Aug 4, 2021
sampaiodiego
approved these changes
Aug 4, 2021
gabriellsh
added a commit
that referenced
this pull request
Aug 10, 2021
* 'develop' of github.com:RocketChat/Rocket.Chat: [FIX] Manually approve new users is not applied to SAML users (#22823) [FIX] applyChatRestictions callback not working for community version (#22839) [FIX] Message update not working in some cases (#22856) [FIX] Broken download link on uploaded files (#22848) [FIX] User is still asked for 2FA confirmation even if 2FA is globally deactivated. (#22801) [FIX] Registration not possible with TOTP and email verification (#22778) [FIX] users registered via third party apps bypass custom required fields (#22396) [FIX] "Click to Join" button is not working if there are no muted users in the room (#22871) [BREAK][ENTERPRISE] CSV file downloaded in the Engagement Dashboard's New Users section contains undefined data (#22862) Fix Local time conversion in the Users By Time of the Day chart (#22836)
|
Thanks a lot for fixing this! Is there any ETA for when this is being included in a release? Neither 3.17.1 nor 3.17.2 include this fix and I was hoping to avoid having to build my own snap that includes the fix 😅 . |
Member
|
@jpoeppel this fix will be released on 3.18 .. we have a release candidate for 3.18 already, we expect to launch the final release on Auth 30th |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Uploaded files had wrong download links when the deploy had a sub directory. This misbehavior was caused by the wrong usage of the rtrim method, the 2nd parameter is a list of chars, not a string (this method was inspired by php)
Issue(s)
Steps to test or reproduce
Further comments