[IMPROVE][APPS] New storage strategy for Apps-Engine file packages#22657
Merged
[IMPROVE][APPS] New storage strategy for Apps-Engine file packages#22657
Conversation
d-gubert
force-pushed
the
apps/change-storage-strategy
branch
from
a863bca to
3de2473
Compare
d-gubert
commented
Jul 21, 2021
* Enable the user to choose a storage for the apps' source code * Rename app storage proxy module * Adjust operation of the app source storage proxy module * Make setting fs path for app storage its own function * Remove log statement
* Migrate apps source file to gridfs * Remove unused dependencies * Convert base64 zip to buffer * Prevent AppServerOrchestrator from initializing twice * Refactor migration to use existing models instead of custom code * Add description for noop on promise catch Co-authored-by: Douglas Gubert <douglas.gubert@gmail.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
thassiov
changed the title
thassiov
approved these changes
Sep 23, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This is an enabler for our initiative to support NPM packages in the Apps-Engine.
Currently, the packages (zip files) for Rocket.Chat Apps are stored as a base64 encoded string in a document in the database, which constrains us due to the size limit of a document in MongoDB (16Mb).
When we allow apps to include NPM packages, the size of the App package itself will be potentially very large (I'm looking at you
node_modules). Thus we'll be changing the strategy to store apps either with GridFS or the host's File System itself.Issue(s)
Steps to test or reproduce
Further comments
Implementation on the Apps-Engine side: RocketChat/Rocket.Chat.Apps-engine#427