This repository was archived by the owner on Nov 5, 2025. It is now read-only.
[NEW] Split app storage into two sources to support multiple app storage types#427
Merged
[NEW] Split app storage into two sources to support multiple app storage types#427
Conversation
… into feat/app-storage
|
This pull request fixes 1 alert when merging 9447fa3 into d3b47d1 - view on LGTM.com fixed alerts:
|
[NEW] Enable require of some native modules and global functions
…-by-setting [FEAT] Add method for changing the app's source storage type
|
This pull request fixes 1 alert when merging fb93bdb into 5e00bb4 - view on LGTM.com fixed alerts:
|
thassiov
approved these changes
Sep 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What? ⛵
Split the IAppStorageItem into two parts:
- The metadata, stored in the same usual collection as today
- The package file, stored separately somewhere else
Create a new storage class to handle the app package
Adapt the installation process to save the app package separately
Adapt the loading process (startup) to fetch the app package
- Handle the new potential error of not being able to fetch the package
Adapt the app update process to also update the app package separately
Adapt the app removal process to also remove the app package separately
PS 👀
https://app.clickup.com/t/8zwxem