[BREAK] LDAP Refactoring by pierre-lehnen-rc · Pull Request #23171 · RocketChat/Rocket.Chat

pierre-lehnen-rc · 2021-09-10T20:31:55Z

No description provided.

package.json

server/lib/ldap/Manager.ts

server/sdk/types/ILDAPService.ts

server/lib/ldap/Manager.ts

ee/server/services2/ldap/service.ts

ee/server/settings/ldap.ts

server/lib/ldap/getLDAPConditionalSetting.ts

server/lib/ldap/Manager.ts

app/importer/server/classes/ImportDataConverter.ts

app/importer/server/classes/VirtualDataConverter.ts

ee/server/services2/ldap/service.ts

package.json

server/startup/migrations/v236.ts

app/utils/server/lib/cron/Cronjobs.ts

definition/IUser.ts

ggazzo

ta bonito mas ta errado ❤️

ee/server/api/index.ts

ee/server/configuration/ldap.ts

ee/server/settings/ldap.ts

client/contexts/ModalContext.ts

client/views/admin/settings/groups/LDAPGroupPage.tsx

Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>

server/lib/ldap/Connection.ts

server/services/ldap/service.ts

app/importer/server/classes/VirtualDataConverter.ts

Co-authored-by: Diego Sampaio <chinello@gmail.com>

lgtm-com · 2021-09-17T16:51:56Z

This pull request introduces 1 alert when merging 01bccdf into 7388867 - view on LGTM.com

new alerts:

1 for Property access on null or undefined

resolved

…to feat/seats-cap-fixes * 'feat/seats-cap' of github.com:RocketChat/Rocket.Chat: Chore: Re-enable session tests on local after removal of mongo-unit (#23263) [BREAK] Moved role-sync and advanced SAML settings to EE (#23107) Remove uneffective conditional Always create seats limit banners Move startup Change occurences of Livechat to omnichannel were applicable (#23199) Regression: Log Sections not respecting Log Level setting (#23230) [BREAK] Removed support of MongoDB 3.4; Deprecated MongoDB 3.6 and 4.0 (#22907) Regression: Fix user registration stuck (#23254) [FIX] Mark agents as unavailable when they logout (#23219) [FIX] Toolbox click not working on Safari(iOS) (#23244) [FIX] Omnichannel On hold chats being forwarded to offline agents (#23185) [BREAK] LDAP Refactoring (#23171) [IMPROVE] Canned response admin settings (#23190) Chore: Update Livechat widget to 1.9.4 (#23198) useEndpoint (#23209) [FIX] Wrong docs link on Omni-Webhook page (#23117)

joker234 · 2021-09-24T12:22:00Z

@pierre-lehnen-rc can you give a brief description what changed or better what needs to be done when upgrading and using the LDAP integration until the stable release 4.0.0? That would be very helpful!

lobo87 · 2021-10-04T12:01:26Z

Im kind of missing the feature where I can map LDAP groups to certain roles in RC. was that removed? didn't find anything related to that.

due to this fact and syncing the users on log in, my admins lost their admin role.

dennisvj · 2021-10-04T13:41:55Z

Im kind of missing the feature where I can map LDAP groups to certain roles in RC. was that removed? didn't find anything related to that.

due to this fact and syncing the users on log in, my admins lost their admin role.

Same here. Have I read it correctly it is now an Enterprise feat (Enhanced LDAP) ?

milton-rucks · 2021-10-04T16:49:31Z

Im kind of missing the feature where I can map LDAP groups to certain roles in RC. was that removed? didn't find anything related to that.
due to this fact and syncing the users on log in, my admins lost their admin role.

Same here. Have I read it correctly it is now an Enterprise feat (Enhanced LDAP) ?

That's correct.

You can find more information here:

Forum announcement:
https://forums.rocket.chat/t/upcoming-changes-to-identity-management-integrations/11994

List of available login methods and features (EE vs CE):
https://docs.rocket.chat/quick-start/identity-management-ee-vs-ce

LDAP Refactoring

29cfe1e

This comment has been minimized.

Sign in to view

pierre-lehnen-rc added 19 commits September 12, 2021 03:25

Fixed some errors

956639d

Unused import

5c1780e

Moved features and changed default values

5c861bc

Fixed issue with data mapping

bdf598b

prettify

a7705c0

Organizing Settings

81eaf7c

Some setting fixes

c8be74f

Test Connection button

5c22e12

Converted LDAP methods to REST API

deb9dcc

Changed setting tab

74ccb17

Setting Migration

8e03186

Merge branch 'develop' into ldap-ts

14d0322

Enabled Migration

a0989ad

Added Documentation Button

ee81bad

Removed old i18n keys

fa67577

new i18n keys for settings

f8085fe

bug fixes

cdcb8b7

Removing old models wherever possible

fcb8f91

Removing references to old models

f43b5a1

pierre-lehnen-rc marked this pull request as ready for review September 15, 2021 06:38

pierre-lehnen-rc added 3 commits September 15, 2021 03:49

Migration bug

7ec1935

Removed comment, unused method and console.log call

89d6abd

Merge branch 'develop' into ldap-ts

115a3c7

sampaiodiego requested changes Sep 15, 2021

View reviewed changes

pierre-lehnen-rc added 2 commits September 15, 2021 22:56

Improved typings and some review items

7c7d7a4

Improved settings.get typings

94b694b

sampaiodiego requested changes Sep 16, 2021

View reviewed changes

ggazzo reviewed Sep 16, 2021

View reviewed changes

app/utils/server/lib/cron/Cronjobs.ts Outdated Show resolved Hide resolved

ggazzo reviewed Sep 16, 2021

View reviewed changes

definition/IUser.ts Outdated Show resolved Hide resolved

ggazzo previously requested changes Sep 16, 2021

View reviewed changes

pierre-lehnen-rc and others added 7 commits September 16, 2021 21:55

Fixed some typings

82b975f

Update client/views/admin/settings/groups/LDAPGroupPage.tsx

128387e

Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>

Update client/views/admin/settings/groups/LDAPGroupPage.tsx

08b194b

Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>

Fixed some issues raised by the PR reviewers

6f4b0c7

Merge branch 'ldap-ts' of github.com:RocketChat/Rocket.Chat into ldap-ts

c6987bc

Comments and prettify

f86fe53

moved the testConnection method to the micro service

121c2cf

pierre-lehnen-rc requested review from ggazzo and sampaiodiego September 17, 2021 06:23

Merge branch 'develop' into ldap-ts

cd38299

sampaiodiego requested changes Sep 17, 2021

View reviewed changes

pierre-lehnen-rc and others added 2 commits September 17, 2021 13:36

Apply suggestions from code review

83952c4

Co-authored-by: Diego Sampaio <chinello@gmail.com>

Merge branch 'develop' into ldap-ts

01bccdf

sampaiodiego previously approved these changes Sep 17, 2021

View reviewed changes

Fixed Import

ab3719c

pierre-lehnen-rc dismissed sampaiodiego’s stale review via ab3719c September 17, 2021 17:01

sampaiodiego approved these changes Sep 17, 2021

View reviewed changes

pierre-lehnen-rc merged commit 26db22b into develop Sep 17, 2021

pierre-lehnen-rc deleted the ldap-ts branch September 17, 2021 17:36

sampaiodiego mentioned this pull request Oct 1, 2021

Release 4.0.0 #23339

Merged

Turbocube644 mentioned this pull request Jun 15, 2022

LDAP Sync failing for users with non alphanumeric chars in username (Resaon: not slugifying username for sync) #24972

Closed

Conversation

pierre-lehnen-rc commented Sep 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ggazzo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lgtm-com bot commented Sep 17, 2021

Uh oh!

joker234 commented Sep 24, 2021

Uh oh!

lobo87 commented Oct 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dennisvj commented Oct 4, 2021

Uh oh!

milton-rucks commented Oct 4, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Comments

pierre-lehnen-rc commented Sep 10, 2021 •

edited

Loading

lobo87 commented Oct 4, 2021 •

edited

Loading