Skip to content

[IMPROVE] Allow Omnichannel to handle huge queues #23392

Merged
sampaiodiego merged 16 commits intodevelopfrom
yalo/fix
Oct 20, 2021
Merged

[IMPROVE] Allow Omnichannel to handle huge queues #23392
sampaiodiego merged 16 commits intodevelopfrom
yalo/fix

Conversation

@KevLehman
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@casalsgh casalsgh modified the milestone: 4.0.2 Oct 12, 2021
@KevLehman KevLehman requested a review from cauefcr October 19, 2021 15:52
@KevLehman KevLehman changed the title Yalo/fix [IMPROVE] Allow Omnichannel to handle huge queues Oct 19, 2021
@murtaza98
Copy link
Contributor

murtaza98 commented Oct 20, 2021

@KevLehman JFYI: There are some conflicts here wrt the new settings interfaces which the team has recently introduced. More details about the change over here 😬

@murtaza98
Copy link
Contributor

Recommending some cleanup tasks since we now no longer need estimatedInactivityCloseTimeAt property on inquiry docs.

We won't need these 2 methods anymore

We can also remove this property from the search filter from here

@murtaza98
Copy link
Contributor

Verified and tested this PR and functionality wise it is working properly 🚀 . So once the merge conflicts are resolved, I think we'll be in good shape to merge it 🎉

cauefcr
cauefcr previously approved these changes Oct 20, 2021
Copy link
Contributor

@cauefcr cauefcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the functionality of the fix and it works, good one @KevLehman, i learned a lot from this PR.

edit: one thing i found was that the Livechat_max_queue_wait_time setting is disabled on the frontend, had to edit the HTML for it to work.

Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be updated with new setting's APIs

@lgtm-com
Copy link

lgtm-com bot commented Oct 20, 2021

This pull request introduces 1 alert when merging b239e56 into 872cf28 - view on LGTM.com

new alerts:

  • 1 for Identical operands

@lgtm-com
Copy link

lgtm-com bot commented Oct 20, 2021

This pull request introduces 1 alert when merging dc2345c into 872cf28 - view on LGTM.com

new alerts:

  • 1 for Identical operands

murtaza98
murtaza98 previously approved these changes Oct 20, 2021
Co-authored-by: Diego Sampaio <chinello@gmail.com>
@casalsgh casalsgh requested a review from sampaiodiego October 20, 2021 23:22
@sampaiodiego sampaiodiego merged commit 18b3526 into develop Oct 20, 2021
@sampaiodiego sampaiodiego deleted the yalo/fix branch October 20, 2021 23:41
@sampaiodiego sampaiodiego mentioned this pull request Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments