Merged
Conversation
* draft getreports api * prettier * fix lint error * fix lint error * fix lint error * add raw model * fix prop type * fix lint * add oldest undefine check * test * fix offset and count * add new migration and fix report history api * add e2e tests * check array and remove API failure and change the migration version * add hidebyid endpoint * add hidebymid method * add test for report hide * fix build * add moderation.info enfpoint and hiddenby fields * add test for mdoeration.info * fix e2e tests * add new property in reporthistoryprop * moderation.history -> moderation.getReports * moderation.hide -> moderation.markChecked * moderation.info -> moderation.reportsByMessage * add additional sort param * add query param * remove deprecated query * add single report detail endpoint * fix link * add test for new API * add reportedBy user details * fix type error and add new count api endpoint * fix type error * fix count api return value * add query to group together reported messages based on message content * update test * add totalcounts for grouped results * reduce data overload * add new count field * update IReport schema and support new fields in Moderation method * try to fix error * revert grouping by message content * update moderation interface * fix type error * add moderation.user.getMessageHistory endpoint * avoid duplicated messsages * fix hidereport api * fix reportsbymsg endpoint * flag deleteMessage method as deprecated * add reported message delete endpoint * add new permissions to the deactivate & reset emoji enfpoints * fix test and try out to append roomnames * fix api errors * add roomname append query * update the ireport schema and also the report function * add more fields in schema * reduce aggregation calls * fix return type of API calls * fix tests and deleteReportedMessages method * add intial migration logic * try to fix type error in moderation.ts * fix the typescript error, and remove migration logic * fix setActiveStatus persmission * fix projection * add count propoerty in IModerationAudit * add _id to usermessages * fix deletmessage function * add new function for reportMessage, deprecate the reportMessage method, try to fix test --------- Co-authored-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
* draft getreports api * prettier * fix lint error * fix lint error * fix lint error * add raw model * fix prop type * fix lint * add oldest undefine check * test * fix offset and count * add new migration and fix report history api * add e2e tests * check array and remove API failure and change the migration version * add hidebyid endpoint * add hidebymid method * add test for report hide * fix build * add moderation.info enfpoint and hiddenby fields * add test for mdoeration.info * fix e2e tests * add new property in reporthistoryprop * moderation.history -> moderation.getReports * moderation.hide -> moderation.markChecked * moderation.info -> moderation.reportsByMessage * add additional sort param * add query param * remove deprecated query * add single report detail endpoint * fix link * add test for new API * add reportedBy user details * fix type error and add new count api endpoint * fix type error * fix count api return value * add query to group together reported messages based on message content * update test * add totalcounts for grouped results * reduce data overload * add new count field * update IReport schema and support new fields in Moderation method * try to fix error * revert grouping by message content * update moderation interface * fix type error * add moderation.user.getMessageHistory endpoint * avoid duplicated messsages * fix hidereport api * fix reportsbymsg endpoint * flag deleteMessage method as deprecated * add reported message delete endpoint * add new permissions to the deactivate & reset emoji enfpoints * fix test and try out to append roomnames * fix api errors * add roomname append query * update the ireport schema and also the report function * add more fields in schema * reduce aggregation calls * fix return type of API calls * fix tests and deleteReportedMessages method * add intial migration logic * try to fix type error in moderation.ts * fix the typescript error, and remove migration logic * fix setActiveStatus persmission * fix projection * add count propoerty in IModerationAudit * add _id to usermessages * fix deletmessage function * add new function for reportMessage, deprecate the reportMessage method, try to fix test --------- Co-authored-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
…hboard' into feat/moderation-dashboard
* fix reportmessage import and archivereportprop * add routes and sample fetch data * define the moderation console table row * add raw context * add groupBymsg function and resolve TS errors * show messages * fix import warnings and introduce a new count api * add reporter user details * add some helpers * fix the moderator actions mutation call, and introduce new context bar * add new message body for parsing mod console messages * add reports vertical context bar * add arg to different acttions * fix refresh data after actions * add message redirect function * change 'view reports' * create hooks for moderation actions * remove footer - not working as expected * add a date range picker * add callout * fix today's report not showing up on console * add delete single message option * fix modal not closing * fix refetching data on individual delete * add context bar actionss * add i18n keys * i missed the 'duplicate messages' * add username column * add new permission to show workspace with moderation permission * remove await from reset avatar * fix lint error * resize avatar * fix type fail for moderation files * respect UI_use_real_name setting * lightning <-> warning ico * fix daterangegpicker * add a extra option to navigate to moderation console * fix use real name setting respect * add a moderate. to query names * moderationalize the i18ns * fix avatar stretch * remove capital words & add a beta tag * beta <-> alpha tag * fix context bar header * close context bar after deleting all messages & hide footer for no results * fix order of view reported messages option & no open new tabs * close context bar on report dismiss and add a beta tag * fix contextmessage ireport <-> imoderationreport * fix lint * add confirmrelinquish option
Codecov Report
@@ Coverage Diff @@
## release-6.2.0 #28962 +/- ##
=================================================
+ Coverage 46.89% 46.98% +0.09%
=================================================
Files 728 729 +1
Lines 13864 13876 +12
Branches 2194 2196 +2
=================================================
+ Hits 6501 6520 +19
+ Misses 7051 7042 -9
- Partials 312 314 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
force-pushed
the
feat/moderation-dashboard
branch
from
04c2f28 to
83a6dc5
Compare
dionisio-bot
bot
removed
the
stat: ready to merge
Member
|
sorry I synced with develop I didnt see the main branch was 6.2.0 thats why the push force |
ggazzo
requested changes
Apr 25, 2023
Member
ggazzo
left a comment
ggazzo
left a comment
There was a problem hiding this comment.
Great job, please check my comments. Beside that I'm a 99.9% sure the implementation considering 'owner', 'moderator' roles are not working as expected, if we want to allow room owners to moderate messages its going to require extra page ( or at least an extra context on the current ModerationConsoleTable) considering the roomId on the moderation.reportsByUsers endpoints as well.
and be careful to not allow one room owner(and not a admint) to be able to see reports from other rooms.
apps/meteor/app/authorization/server/functions/upsertPermissions.ts
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/room/hooks/useUserInfoActions/actions/useRedirectModerationConsole.ts
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/admin/moderation/ModerationConsoleTable.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/admin/moderation/ModerationConsoleTableRow.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/admin/moderation/ModerationConsoleTable.tsx
Outdated
Show resolved
Hide resolved
ggazzo
requested changes
May 4, 2023
ggazzo
previously approved these changes
May 5, 2023
ggazzo
previously approved these changes
May 5, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Release PR for the
feat/moderation-dashboardimplementing the Beta version of the Moderation Console. For more details & some previews on Moderation Console, read here -> #27961 (comment)Issue(s)
Steps to test or reproduce
Further comments