chore: move utilitary functions out of ee folder#31207
Merged
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #31207 +/- ##
===========================================
- Coverage 54.53% 54.50% -0.03%
===========================================
Files 2271 2273 +2
Lines 50067 50169 +102
Branches 10211 10377 +166
===========================================
+ Hits 27306 27347 +41
- Misses 20291 20347 +56
- Partials 2470 2475 +5
Flags with carried forward coverage won't be shown. Click here to find out more. |
KevLehman
approved these changes
Dec 11, 2023
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Mar 6, 2024
…tMarkdown * 'develop' of github.com:RocketChat/Rocket.Chat: chore: improve useJumpToMessage (#31907) feat: Add `link` action to composer toolbar (#31679) chore: replace `PaletteStyleTag` in favor of fuselage component (#31839) fix: presence for mobiles with duplicated connections (#31895) fix: New users are not automatically inserted in auto-join rooms inside default teams (#31720) fix: livechat agent status set to available after reactivation (#31651) chore: Deprecate `insertOrUpdateUser` method (#31884) chore: update ts version on recently merged package (#31885) chore: move utilitary functions out of ee folder (#31207) chore: Remove references to EE code from the app bridges (#31757) fix: Room import doesn't honor the specified owner (#31803) fix: message parser emphasis black hole (#31868) chore: remove hardcoded position for message date (#31866) feat: show date on message's scroll (#31572) chore: `RoomHeader` keyboard navigability (#31837) fix: Login page breaking when handling not expected errors (#31804)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Move utilitary functions used by CE code out of the EE folder.
Issue(s)
Steps to test or reproduce
Further comments