fix: Login page breaking when handling not expected errors#31804
Merged
kodiakhq[bot] merged 4 commits intodevelopfrom Feb 29, 2024
Merged
fix: Login page breaking when handling not expected errors#31804kodiakhq[bot] merged 4 commits intodevelopfrom
kodiakhq[bot] merged 4 commits intodevelopfrom
Conversation
🦋 Changeset detectedLatest commit: ba6a6ca The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #31804 +/- ##
===========================================
- Coverage 54.61% 54.61% -0.01%
===========================================
Files 2275 2274 -1
Lines 50154 50140 -14
Branches 10228 10228
===========================================
- Hits 27391 27382 -9
+ Misses 20287 20276 -11
- Partials 2476 2482 +6
Flags with carried forward coverage won't be shown. Click here to find out more. |
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Feb 29, 2024
…LinkAction * 'develop' of github.com:RocketChat/Rocket.Chat: (41 commits) fix: Login page breaking when handling not expected errors (#31804) chore: Upgrade `react-virtuoso` (#31843) chore: Refactor & Improve Livechat Widget API (#30924) i18n: Rocket.Chat.Livechat language update from LingoHub 🤖 on 2024-02-28Z (#31855) i18n: Rocket.Chat language update from LingoHub 🤖 on 2024-02-28Z (#31856) chore: Sidebar toolbar keyboard navigation (#31846) fix(eslint-config): react config file export (#31845) chore: cache ui-context package (#31805) fix: make lifecycle methods part of inherited class in federation services (#31844) fix: client ignoring offline presence updates (#31833) test: saml login custom role (#31830) chore: `VideoConfPopup` keyboard navigability (#31831) fix: revert status websocket payload changes (#31823) chore: `UserCard` focus improvements (#31812) regression: Prevent storing lastFocused message by click event (#31819) chor: allow offline development build test: make calendar api tests fully independent (#31785) fix: Correct display of discussion names in sidebar search (#31701) bump meteor 2.15 (#31799) test: make apps api tests fully independent (#31787) ...
gabriellsh
added a commit
that referenced
this pull request
Mar 6, 2024
…tMarkdown * 'develop' of github.com:RocketChat/Rocket.Chat: chore: improve useJumpToMessage (#31907) feat: Add `link` action to composer toolbar (#31679) chore: replace `PaletteStyleTag` in favor of fuselage component (#31839) fix: presence for mobiles with duplicated connections (#31895) fix: New users are not automatically inserted in auto-join rooms inside default teams (#31720) fix: livechat agent status set to available after reactivation (#31651) chore: Deprecate `insertOrUpdateUser` method (#31884) chore: update ts version on recently merged package (#31885) chore: move utilitary functions out of ee folder (#31207) chore: Remove references to EE code from the app bridges (#31757) fix: Room import doesn't honor the specified owner (#31803) fix: message parser emphasis black hole (#31868) chore: remove hardcoded position for message date (#31866) feat: show date on message's scroll (#31572) chore: `RoomHeader` keyboard navigability (#31837) fix: Login page breaking when handling not expected errors (#31804)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
fix #31504
CORE-89
Steps to test or reproduce
Further comments