fix: Correct display of discussion names in sidebar search#31701
Merged
kodiakhq[bot] merged 10 commits intodevelopfrom Feb 22, 2024
Merged
fix: Correct display of discussion names in sidebar search#31701kodiakhq[bot] merged 10 commits intodevelopfrom
kodiakhq[bot] merged 10 commits intodevelopfrom
Conversation
🦋 Changeset detectedLatest commit: 832cdf6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #31701 +/- ##
===========================================
- Coverage 54.52% 54.48% -0.05%
===========================================
Files 2272 2271 -1
Lines 50103 50089 -14
Branches 10219 10219
===========================================
- Hits 27321 27289 -32
- Misses 20309 20327 +18
Partials 2473 2473
Flags with carried forward coverage won't be shown. Click here to find out more. |
matheusbsilva137
previously approved these changes
Feb 8, 2024
MarcosSpessatto
suggested changes
Feb 8, 2024
Contributor
MarcosSpessatto
left a comment
MarcosSpessatto
left a comment
There was a problem hiding this comment.
Can we add a test case to cover this scenario?
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Member
Author
Hey @MarcosSpessatto I have added test for this scenario. It tests discussion search in both cases when |
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
…search-discussion-name-handling
dionisio-bot
bot
added
the
stat: ready to merge
gabriellsh
approved these changes
Feb 22, 2024
MarcosSpessatto
approved these changes
Feb 22, 2024
dionisio-bot
bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Feb 29, 2024
…LinkAction * 'develop' of github.com:RocketChat/Rocket.Chat: (41 commits) fix: Login page breaking when handling not expected errors (#31804) chore: Upgrade `react-virtuoso` (#31843) chore: Refactor & Improve Livechat Widget API (#30924) i18n: Rocket.Chat.Livechat language update from LingoHub 🤖 on 2024-02-28Z (#31855) i18n: Rocket.Chat language update from LingoHub 🤖 on 2024-02-28Z (#31856) chore: Sidebar toolbar keyboard navigation (#31846) fix(eslint-config): react config file export (#31845) chore: cache ui-context package (#31805) fix: make lifecycle methods part of inherited class in federation services (#31844) fix: client ignoring offline presence updates (#31833) test: saml login custom role (#31830) chore: `VideoConfPopup` keyboard navigability (#31831) fix: revert status websocket payload changes (#31823) chore: `UserCard` focus improvements (#31812) regression: Prevent storing lastFocused message by click event (#31819) chor: allow offline development build test: make calendar api tests fully independent (#31785) fix: Correct display of discussion names in sidebar search (#31701) bump meteor 2.15 (#31799) test: make apps api tests fully independent (#31787) ...
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This fix alters the spotlight search endpoint method to include the
prid(parent room ID) for rooms. This adjustment ensures that the client correctly identifies discussions and displays their names instead of IDs in the sidebar search results. This change resolves the issue where discussion IDs were displayed when the "Allow Special Characters in Room Names" setting was disabled, aligning the behavior with the search results when the setting is enabled.Issue(s)
Fixes issue where discussion names were incorrectly displayed as IDs in sidebar search results under specific conditions.
Steps to test or reproduce
Further comments
SUP-410