fix: make lifecycle methods part of inherited class in federation services

[debdutdeb]

• fix: make lifecycle methods part of inherited class in federation services
• chore: add changeset

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

[changeset-bot]

🦋 Changeset detected

Latest commit: 6a9a050

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/api-client	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/models	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[debdutdeb]

@MarcosSpessatto quickest one i could think, maybe we could just move them without calling super? i didn't see them used anywhere else but just to be sure.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.63%. Comparing base (cd5cbe2) to head (6a9a050).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #31844      +/-   ##
===========================================
+ Coverage    54.49%   54.63%   +0.13%     
===========================================
  Files         2270     2275       +5     
  Lines        50095    50157      +62     
  Branches     10219    10229      +10     
===========================================
+ Hits         27300    27401     +101     
+ Misses       20322    20278      -44     
- Partials      2473     2478       +5     

Flag	Coverage Δ
e2e	53.57% <ø> (+0.08%)	⬆️
e2e-api	40.09% <ø> (+0.29%)	⬆️
unit	76.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[MarcosSpessatto]

@MarcosSpessatto quickest one i could think, maybe we could just move them without calling super? i didn't see them used anywhere else but just to be sure.

You are right, we can move them, I don't know why I've put this on the base class 🤦‍♂️

[MarcosSpessatto]

Can we follow your suggestion and move them lifecycle methods to the service class instead? I think it would be clearer. Approving that

[debdutdeb]

actually looks like I can't that easily -
this

Rocket.Chat/apps/meteor/ee/server/local-services/federation/service.ts

Line 138 in 9c06e1d

await super.stopped();

calls this

Rocket.Chat/apps/meteor/server/services/federation/service.ts

Line 300 in 9c06e1d

public async stopped(): Promise<void> {

and is then shared with ce federation service.
same for setupFederation in create