Skip to content

chore: Refactor & Improve Livechat Widget API#30924

Merged
ggazzo merged 24 commits intodevelopfrom
hooks-ts
Feb 29, 2024
Merged

chore: Refactor & Improve Livechat Widget API#30924
ggazzo merged 24 commits intodevelopfrom
hooks-ts

Conversation

@MartinSchoeler
Copy link
Copy Markdown
Member

@MartinSchoeler MartinSchoeler commented Nov 10, 2023

TODO

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Nov 10, 2023

🦋 Changeset detected

Latest commit: 654cb19

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@rocket.chat/livechat Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.57%. Comparing base (cd5cbe2) to head (654cb19).
Report is 9 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30924      +/-   ##
===========================================
+ Coverage    54.49%   54.57%   +0.07%     
===========================================
  Files         2270     2276       +6     
  Lines        50095    50148      +53     
  Branches     10219    10275      +56     
===========================================
+ Hits         27300    27368      +68     
- Misses       20322    20334      +12     
+ Partials      2473     2446      -27     
Flag Coverage Δ
unit 76.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleksandernsilva aleksandernsilva marked this pull request as ready for review February 27, 2024 18:46
@aleksandernsilva aleksandernsilva requested review from a team as code owners February 27, 2024 18:46
@@ -0,0 +1,3 @@
export function isDefined<T>(val: T | undefined | null): val is T {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tassoevan
tassoevan previously approved these changes Feb 28, 2024
@tassoevan tassoevan added this to the 6.7 milestone Feb 28, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 28, 2024
@aleksandernsilva aleksandernsilva marked this pull request as draft February 28, 2024 18:40
@aleksandernsilva aleksandernsilva marked this pull request as ready for review February 28, 2024 18:44
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Feb 29, 2024
@ggazzo ggazzo merged commit d92c0c7 into develop Feb 29, 2024
@ggazzo ggazzo deleted the hooks-ts branch February 29, 2024 13:13
gabriellsh added a commit that referenced this pull request Feb 29, 2024
…tMarkdown

* 'develop' of github.com:RocketChat/Rocket.Chat:
  chore: Refactor & Improve Livechat Widget API (#30924)
  i18n: Rocket.Chat.Livechat language update from LingoHub 🤖 on 2024-02-28Z (#31855)
  i18n: Rocket.Chat language update from LingoHub 🤖 on 2024-02-28Z (#31856)
  chore: Sidebar toolbar keyboard navigation (#31846)
  fix(eslint-config): react config file export (#31845)
  chore: cache ui-context package (#31805)
  fix: make lifecycle methods part of inherited class in federation services (#31844)
  fix: client ignoring offline presence updates (#31833)
gabriellsh added a commit that referenced this pull request Feb 29, 2024
…LinkAction

* 'develop' of github.com:RocketChat/Rocket.Chat: (41 commits)
  fix: Login page breaking when handling not expected errors (#31804)
  chore: Upgrade `react-virtuoso` (#31843)
  chore: Refactor & Improve Livechat Widget API (#30924)
  i18n: Rocket.Chat.Livechat language update from LingoHub 🤖 on 2024-02-28Z (#31855)
  i18n: Rocket.Chat language update from LingoHub 🤖 on 2024-02-28Z (#31856)
  chore: Sidebar toolbar keyboard navigation (#31846)
  fix(eslint-config): react config file export (#31845)
  chore: cache ui-context package (#31805)
  fix: make lifecycle methods part of inherited class in federation services (#31844)
  fix: client ignoring offline presence updates (#31833)
  test: saml login custom role (#31830)
  chore: `VideoConfPopup` keyboard navigability (#31831)
  fix: revert status websocket payload changes (#31823)
  chore: `UserCard` focus improvements (#31812)
  regression: Prevent storing lastFocused message by click event (#31819)
  chor: allow offline development build
  test: make calendar api tests fully independent (#31785)
  fix: Correct display of discussion names in sidebar search (#31701)
  bump meteor 2.15 (#31799)
  test: make apps api tests fully independent (#31787)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants