Skip to content

fix: username not changing when editing incoming webhook#31442

Open
dieselftw wants to merge 6 commits intoRocketChat:developfrom
dieselftw:fix/incoming-integration-username
Open

fix: username not changing when editing incoming webhook#31442
dieselftw wants to merge 6 commits intoRocketChat:developfrom
dieselftw:fix/incoming-integration-username

Conversation

@dieselftw
Copy link
Copy Markdown
Contributor

@dieselftw dieselftw commented Jan 13, 2024

Proposed changes (including videos or screenshots)

Currently, changing the "Post as" field while editing incoming webhooks does not change the value. This PR aims to resolve the same.

Before:

2024-01-13.23-51-47.mp4

After:

2024-01-13.23-50-41.mp4

Issue(s)

fixes #31425

Steps to test or reproduce

  1. Open an existing webhook integration
  2. Change the contents of the Post as field
  3. Save it

Further comments

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jan 13, 2024

⚠️ No Changeset found

Latest commit: f9a4072

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 13, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.31%. Comparing base (cb9c6ba) to head (f9a4072).
⚠️ Report is 3659 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31442      +/-   ##
===========================================
- Coverage    54.33%   54.31%   -0.02%     
===========================================
  Files         2276     2269       -7     
  Lines        50124    50040      -84     
  Branches     10220    10358     +138     
===========================================
- Hits         27233    27179      -54     
+ Misses       20406    20375      -31     
- Partials      2485     2486       +1     
Flag Coverage Δ
e2e 53.13% <ø> (-0.04%) ⬇️
e2e-api 39.88% <ø> (+19.12%) ⬆️
unit 76.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dieselftw
Copy link
Copy Markdown
Contributor Author

@gabriellsh @hugocostadev can I get a review on this? I feel like it's an important fix. Thanks! :)

@dieselftw
Copy link
Copy Markdown
Contributor Author

@juliajforesti is there a problem with this fix? I'd appreciate some feedback! Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

Post as field can not be changed in Webhook Integration

3 participants