fix: Incorrect initial data not allowing edit webhooks properly#31948
Merged
kodiakhq[bot] merged 7 commits intoRocketChat:developfrom Mar 18, 2024
Merged
fix: Incorrect initial data not allowing edit webhooks properly#31948kodiakhq[bot] merged 7 commits intoRocketChat:developfrom
kodiakhq[bot] merged 7 commits intoRocketChat:developfrom
Conversation
🦋 Changeset detectedLatest commit: 8d08841 The changes in this PR will be included in the next version bump. This PR includes changesets to release 31 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #31948 +/- ##
===========================================
- Coverage 54.62% 54.61% -0.01%
===========================================
Files 2292 2295 +3
Lines 50540 50575 +35
Branches 10320 10327 +7
===========================================
+ Hits 27608 27623 +15
- Misses 20438 20458 +20
Partials 2494 2494
Flags with carried forward coverage won't be shown. Click here to find out more. |
dieselftw
changed the title
dougfabris
requested changes
Mar 11, 2024
Member
dougfabris
left a comment
dougfabris
left a comment
There was a problem hiding this comment.
Nice catch, go ahead and make the fixes on the incoming as well
Contributor
Author
|
I've changed all other fields @dougfabris, I'm assuming this is optimal, let me know if you'd prefer changing only certain fields. |
Contributor
Author
|
Hey again @dougfabris, sorry for the tag, but I made a few PRs for bug fixes. Would really appreciate a review so these tickets can be solved and closed. Thanks! |
dougfabris
changed the title
dionisio-bot
bot
added
stat: ready to merge
dougfabris
changed the title
dougfabris
approved these changes
Mar 18, 2024
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
removed
the
stat: ready to merge
dougfabris
added
the
stat: ready to merge
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The logic for toggle switches in
EditIncomingWebhook.tsxandEditOutgoingWebhook.tsxisn't implemented correctly right now.enabled: webhookData?.enabled || true,will always return true, hence the switch will always be in the 'on' state.Before:
2024-03-09.18-22-03.mp4
After:
2024-03-09.18-20-54.mp4
Since the intended use is to initialize the toggle switch with
truevalue (during creation) and take the actual value when it's available,??operator would logically work best here in my opinion.Issue(s)
fixes #31943
Steps to test or reproduce
Further comments
EditIncomingWebhook.tsxhas a similar issue but there the "Enabled" value is always initialized to false (which is confusing and unnecessary). That can be fixed and merged in this pull request as well if this fix is deemed correct.I've only edited the affected fields for now, but this should ideally be done in all fields.