fix: UI allowing to mark room as favorite despite room was not a default room#32063
Merged
kodiakhq[bot] merged 10 commits intodevelopfrom Apr 3, 2024
Merged
fix: UI allowing to mark room as favorite despite room was not a default room#32063kodiakhq[bot] merged 10 commits intodevelopfrom
default room#32063kodiakhq[bot] merged 10 commits intodevelopfrom
Conversation
🦋 Changeset detectedLatest commit: e948bf5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 31 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32063 +/- ##
===========================================
+ Coverage 54.76% 54.79% +0.03%
===========================================
Files 2298 2302 +4
Lines 50779 50828 +49
Branches 10394 10402 +8
===========================================
+ Hits 27807 27853 +46
Misses 20468 20468
- Partials 2504 2507 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
MarcosSpessatto
suggested changes
Mar 26, 2024
Contributor
MarcosSpessatto
left a comment
MarcosSpessatto
left a comment
There was a problem hiding this comment.
Can we create UI tests as well? Asking, since the majority of this problem is the UI not respecting the feature at all.
MarcosSpessatto
suggested changes
Mar 26, 2024
MarcosSpessatto
approved these changes
Mar 27, 2024
dionisio-bot
bot
added
the
stat: ready to merge
dougfabris
approved these changes
Apr 3, 2024
Member
dougfabris
left a comment
dougfabris
left a comment
There was a problem hiding this comment.
LGTM!
Approving on behalf of frontend!
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
|
dionisio-bot
bot
added
stat: QA assured
dionisio-bot
bot
removed
the
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Apr 4, 2024
* develop: (71 commits) fix: search room not reactive after room name changes (#32123) test: fix `should edit name of targetChannel` flaky test (#32121) fix: UI allowing to mark room as favorite despite room was not a `default` room (#32063) chore: Remove duplicated `ChannelDeletionTable` (#32114) test(livechat): fix Department flaky test (#32102) test(livechat): File upload settings (#32060) test: contact center after hook calling wrong endpoint (#32094) fix(livechat): registering guest multiple times cause message loss (#32069) test: allow csp for livechat tests (#32116) chore: Move portals to the portals folder (#32090) test: `InitialData.insertAdminUserFromEnv` (#32066) fix: `CSP` error right after `setInlineScriptsAllowed` (#32108) chore: Create/Edit room consistency (#31960) chore: Remove references to EE code from the app events (#31926) test(Livechat): Clean up after registerGuest() test (#32092) test: make presence api tests fully independent (#31782) test: make roles fully independent (#31783) chore: bump version to 7.0.0-develop test: make login api tests fully independent (#31786) fix!: api login should not suggest which credential is wrong (#32086) ...
gabriellsh
added a commit
that referenced
this pull request
Apr 4, 2024
* origin: refactor: `TeamsChannels` to typescript (#32109) fix: search room not reactive after room name changes (#32123) test: fix `should edit name of targetChannel` flaky test (#32121) fix: UI allowing to mark room as favorite despite room was not a `default` room (#32063) chore: Remove duplicated `ChannelDeletionTable` (#32114) test(livechat): fix Department flaky test (#32102) test(livechat): File upload settings (#32060) test: contact center after hook calling wrong endpoint (#32094) fix(livechat): registering guest multiple times cause message loss (#32069) test: allow csp for livechat tests (#32116) chore: Move portals to the portals folder (#32090) test: `InitialData.insertAdminUserFromEnv` (#32066) fix: `CSP` error right after `setInlineScriptsAllowed` (#32108)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://rocketchat.atlassian.net/browse/SUP-514
defaultis not trueProposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
This was only a UI issue, BE was ignoring the change to non default rooms.