Skip to content

test: InitialData.insertAdminUserFromEnv#32066

Merged
kodiakhq[bot] merged 7 commits intodevelopfrom
CORE-194
Apr 2, 2024
Merged

test: InitialData.insertAdminUserFromEnv#32066
kodiakhq[bot] merged 7 commits intodevelopfrom
CORE-194

Conversation

@KevLehman
Copy link
Copy Markdown
Member

@KevLehman KevLehman commented Mar 25, 2024

https://rocketchat.atlassian.net/browse/CORE-194

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

  • Abstract logic for creating an admin user from environment variables into function
  • Unit tests for newly created function

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 25, 2024

⚠️ No Changeset found

Latest commit: 5dc6075

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@KevLehman KevLehman changed the title tests: InitialData.insertAdminUserFromEnv test: InitialData.insertAdminUserFromEnv Mar 25, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 96.77419% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 54.78%. Comparing base (fc97aed) to head (5dc6075).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32066      +/-   ##
===========================================
+ Coverage    54.70%   54.78%   +0.07%     
===========================================
  Files         2302     2302              
  Lines        50814    50828      +14     
  Branches     10401    10383      -18     
===========================================
+ Hits         27798    27844      +46     
+ Misses       20508    20476      -32     
  Partials      2508     2508              
Flag Coverage Δ
e2e 53.73% <ø> (+<0.01%) ⬆️
e2e-api 40.04% <6.66%> (+0.02%) ⬆️
unit 75.39% <93.54%> (-0.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 25, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 26, 2024
@KevLehman KevLehman marked this pull request as ready for review March 26, 2024 15:31
@KevLehman KevLehman requested a review from a team as a code owner March 26, 2024 15:31
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Mar 26, 2024
Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 1, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Apr 1, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Apr 2, 2024
@kodiakhq kodiakhq bot merged commit fe93a2b into develop Apr 2, 2024
@kodiakhq kodiakhq bot deleted the CORE-194 branch April 2, 2024 19:35
gabriellsh added a commit that referenced this pull request Apr 4, 2024
* develop: (71 commits)
  fix: search room not reactive after room name changes (#32123)
  test: fix `should edit name of targetChannel` flaky test (#32121)
  fix: UI allowing to mark room as favorite despite room was not a `default` room (#32063)
  chore: Remove duplicated `ChannelDeletionTable` (#32114)
  test(livechat): fix Department flaky test (#32102)
  test(livechat): File upload settings (#32060)
  test: contact center after hook calling wrong endpoint (#32094)
  fix(livechat): registering guest multiple times cause message loss (#32069)
  test: allow csp for livechat tests (#32116)
  chore: Move portals to the portals folder (#32090)
  test: `InitialData.insertAdminUserFromEnv` (#32066)
  fix: `CSP` error right after `setInlineScriptsAllowed` (#32108)
  chore: Create/Edit room consistency (#31960)
  chore: Remove references to EE code from the app events (#31926)
  test(Livechat): Clean up after registerGuest() test (#32092)
  test: make presence api tests fully independent (#31782)
  test: make roles fully independent (#31783)
  chore: bump version to 7.0.0-develop
  test: make login api tests fully independent (#31786)
  fix!: api login should not suggest which credential is wrong (#32086)
  ...
gabriellsh added a commit that referenced this pull request Apr 4, 2024
* origin:
  refactor: `TeamsChannels` to typescript (#32109)
  fix: search room not reactive after room name changes (#32123)
  test: fix `should edit name of targetChannel` flaky test (#32121)
  fix: UI allowing to mark room as favorite despite room was not a `default` room (#32063)
  chore: Remove duplicated `ChannelDeletionTable` (#32114)
  test(livechat): fix Department flaky test (#32102)
  test(livechat): File upload settings (#32060)
  test: contact center after hook calling wrong endpoint (#32094)
  fix(livechat): registering guest multiple times cause message loss (#32069)
  test: allow csp for livechat tests (#32116)
  chore: Move portals to the portals folder (#32090)
  test: `InitialData.insertAdminUserFromEnv` (#32066)
  fix: `CSP` error right after `setInlineScriptsAllowed` (#32108)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants