Skip to content

chore: including x.com hostname to Twitter oembed#32267

Merged
ggazzo merged 1 commit intodevelopfrom
chore/including-X-to-twiiter-oembed
Apr 23, 2024
Merged

chore: including x.com hostname to Twitter oembed#32267
ggazzo merged 1 commit intodevelopfrom
chore/including-X-to-twiiter-oembed

Conversation

@hugocostadev
Copy link
Copy Markdown
Contributor

@hugocostadev hugocostadev commented Apr 19, 2024

Proposed changes (including videos or screenshots)

Twitter/X links can be both twitter.com and/or x.com
Rocket.Chat was only checking twitter.com to embed the post with our OEmbedProvider.
I've fixed this by changing the regex responsible to do this match.

Before:
image

After:
image

Issue(s)

Steps to test or reproduce

Further comments

Since it's a chore and didn't create a test case for that, since it does not exist too

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 19, 2024

⚠️ No Changeset found

Latest commit: c603c59

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hugocostadev hugocostadev added this to the 6.8 milestone Apr 19, 2024
@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Apr 19, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@hugocostadev hugocostadev requested a review from ggazzo April 19, 2024 13:20
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.30%. Comparing base (b235c12) to head (c603c59).
Report is 27 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32267      +/-   ##
===========================================
+ Coverage    53.68%   55.30%   +1.61%     
===========================================
  Files         2298     2313      +15     
  Lines        50518    51017     +499     
  Branches     10344    10452     +108     
===========================================
+ Hits         27123    28216    +1093     
+ Misses       20959    20290     -669     
- Partials      2436     2511      +75     
Flag Coverage Δ
e2e 54.63% <ø> (+3.00%) ⬆️
unit 75.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Apr 23, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 23, 2024
@ggazzo ggazzo merged commit d38e112 into develop Apr 23, 2024
@ggazzo ggazzo deleted the chore/including-X-to-twiiter-oembed branch April 23, 2024 12:48
gabriellsh added a commit that referenced this pull request Apr 23, 2024
…engagementMDM

* 'develop' of github.com:RocketChat/Rocket.Chat:
  chore: including x.com hostname to Twitter oembed (#32267)
  feat: node-gcm deprecation (#32208)
  chore: Deprecate mute/unmute meteor methods and convert to endpoint (#31811)
  fix:  Wrong Business hours validations between different weeks (#32287)
  chore: Force logout live clients on E2EE keys reset changes (#32291)
  ci: skip update version message for TEST_MODE=true (#32293)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants