chore: including x.com hostname to Twitter oembed#32267
Conversation
|
|
Looks like this PR is ready to merge! 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32267 +/- ##
===========================================
+ Coverage 53.68% 55.30% +1.61%
===========================================
Files 2298 2313 +15
Lines 50518 51017 +499
Branches 10344 10452 +108
===========================================
+ Hits 27123 28216 +1093
+ Misses 20959 20290 -669
- Partials 2436 2511 +75
Flags with carried forward coverage won't be shown. Click here to find out more. |
…engagementMDM * 'develop' of github.com:RocketChat/Rocket.Chat: chore: including x.com hostname to Twitter oembed (#32267) feat: node-gcm deprecation (#32208) chore: Deprecate mute/unmute meteor methods and convert to endpoint (#31811) fix: Wrong Business hours validations between different weeks (#32287) chore: Force logout live clients on E2EE keys reset changes (#32291) ci: skip update version message for TEST_MODE=true (#32293)
Proposed changes (including videos or screenshots)
Twitter/X links can be both twitter.com and/or x.com
Rocket.Chat was only checking twitter.com to embed the post with our OEmbedProvider.
I've fixed this by changing the regex responsible to do this match.
Before:

After:

Issue(s)
Steps to test or reproduce
Further comments
Since it's a
choreand didn't create a test case for that, since it does not exist too