fix: Wrong Business hours validations between different weeks#32287
Merged
kodiakhq[bot] merged 4 commits intodevelopfrom Apr 23, 2024
Merged
fix: Wrong Business hours validations between different weeks#32287kodiakhq[bot] merged 4 commits intodevelopfrom
kodiakhq[bot] merged 4 commits intodevelopfrom
Conversation
🦋 Changeset detectedLatest commit: a80db4d The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32287 +/- ##
===========================================
+ Coverage 52.70% 55.47% +2.76%
===========================================
Files 2112 2330 +218
Lines 47953 51376 +3423
Branches 9773 10514 +741
===========================================
+ Hits 25274 28501 +3227
+ Misses 20389 20367 -22
- Partials 2290 2508 +218
Flags with carried forward coverage won't be shown. Click here to find out more. |
Contributor
|
Looks like this PR is ready to merge! 🎉 |
MarcosSpessatto
previously requested changes
Apr 22, 2024
Contributor
MarcosSpessatto
left a comment
MarcosSpessatto
left a comment
There was a problem hiding this comment.
Can we create a changeset?
MarcosSpessatto
approved these changes
Apr 23, 2024
MartinSchoeler
approved these changes
Apr 23, 2024
MartinSchoeler
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Merged
gabriellsh
added a commit
that referenced
this pull request
Apr 23, 2024
…engagementMDM * 'develop' of github.com:RocketChat/Rocket.Chat: chore: including x.com hostname to Twitter oembed (#32267) feat: node-gcm deprecation (#32208) chore: Deprecate mute/unmute meteor methods and convert to endpoint (#31811) fix: Wrong Business hours validations between different weeks (#32287) chore: Force logout live clients on E2EE keys reset changes (#32291) ci: skip update version message for TEST_MODE=true (#32293)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
it seems that Business Hours doesnt work properly in special scenarios:
Business Hoursis configured in a different timezoneBusiness Hoursis already SundayThats the reason why CI refused to pass saturday 6pm
Issue(s)
Steps to test or reproduce
Further comments
CORE-306