Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: a87c74d The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32517 +/- ##
===========================================
- Coverage 56.67% 55.67% -1.00%
===========================================
Files 2504 2631 +127
Lines 55518 57135 +1617
Branches 11440 11833 +393
===========================================
+ Hits 31464 31810 +346
- Misses 21370 22612 +1242
- Partials 2684 2713 +29
Flags with carried forward coverage won't be shown. Click here to find out more. |
juliajforesti
force-pushed
the
feat/new-navigation
branch
from
f32d17b to
afa560d
Compare
* chore: update Room Header paddings and sizes * feat(ui-client): `HeaderSubContent` component * chore: move topic and leader to `RoomHeader` sub content * chore: delete deprecated `LeaderBar` * feat: `HeaderSection` * fix: lint * fix test * chore: room not found and skeleton adjustments * feat: new `Contextualbar` sizes * fix: HeaderContentRow width * feat: Header and SearchList heights * bump fuselage@dev * feat: `TeamsChannels` search section * move HeaderSection inside RoomBody (wip) * chore: improve animation * feat: remove neg margin from HeaderSection * chore: rename hook * remove imports * feat: `RoomHeaderSection` component * feat: `AnnouncementBanner` * feat: `RoomBanner` component * chore: rename * test: RoomBanner selectors * fix test * feat: `Add topic` section on banner * chore: changeset * fix icons version with fuselage@dev * chore: refinement * review * chore: RoomLeader icon title * chore: `ComposerUserActionIndicator` size and typography changes * Update apps/meteor/client/views/room/RoomAnnouncement/AnnouncementComponent.tsx Co-authored-by: Douglas Fabris <devfabris@gmail.com> * chore: `RoomBannerContent` padding * Update packages/ui-client/src/components/RoomBanner/RoomBanner.tsx Co-authored-by: Douglas Fabris <devfabris@gmail.com> * chore: import tweaks * bump fuselage * fix banner locator * test: truncated width --------- Co-authored-by: Douglas Fabris <devfabris@gmail.com>
juliajforesti
force-pushed
the
feat/new-navigation
branch
3 times, most recently
from
c1ff3e8 to
c2e6e2f
Compare
juliajforesti
force-pushed
the
feat/new-navigation
branch
from
c2e6e2f to
6c1d08e
Compare
* bump fuselage * feat preview * feat: navigation preview duplicate changes * feat: `Contextualbar` feat on/off * feat: `ui-client/Header` V2 * chore: reexport `ui-client/Header` in `client/components with feat preview * chore: import `Header` components from `client/components` * contextualbarActions * Header stories * forward refs * test: channel-management * Contextualbar imports * feat: `NavBarV2` * feat: `NavBarV2` * git reset * chore: `client/sidebarv1` * chore: `sidebarv2` * chore: rename `sidebarv1` -> `sidebar` * chore: `ComposerUserActionIndicator` * feat: apply navbar feat.prev * review * revert * fix `HeaderTagSkeleton` props * add TODO * review: replace deprecated `useRoute` with `useRouter` * review: replace deprecated `useMutableCallback` with `useEffectEvent` * Extract component props * Normalize component modules * Normalize component modules * Normalize component modules * Fix broken file extension * Normalize component modules --------- Co-authored-by: Tasso <tasso.evangelista@rocket.chat>
juliajforesti
force-pushed
the
feat/new-navigation
branch
from
013b64d to
6f8f034
Compare
tassoevan
previously approved these changes
Jul 11, 2024
tassoevan
added
the
stat: QA assured
tassoevan
approved these changes
Jul 12, 2024
dionisio-bot
bot
added
the
stat: ready to merge
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
epics:
SIDE-17
SIDE-35
SIDE-53
SIDE-78
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments