feat: Improve UX from "Action Buttons" in `RoomInfo` by tiagoevanp · Pull Request #32632 · RocketChat/Rocket.Chat

tiagoevanp · 2024-06-19T04:31:20Z

Proposed changes (including videos or screenshots)

Improve the UX from "Action Buttons" inside the contextualbar in RoomInfo component

Before:

After:

Issue(s)

Steps to test or reproduce

Further comments

CORE-464

dionisio-bot · 2024-06-19T04:31:23Z

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

changeset-bot · 2024-06-19T04:31:23Z

🦋 Changeset detected

Latest commit: e08a7a2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/api-client	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/models	Patch
@rocket.chat/ui-avatar	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov · 2024-06-19T04:37:10Z

Codecov Report

Attention: Patch coverage is 71.42857% with 8 lines in your changes missing coverage. Please review.

Project coverage is 55.63%. Comparing base (703af95) to head (e08a7a2).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #32632      +/-   ##
===========================================
+ Coverage    55.56%   55.63%   +0.07%     
===========================================
  Files         2635     2637       +2     
  Lines        57292    57308      +16     
  Branches     11865    11868       +3     
===========================================
+ Hits         31834    31884      +50     
+ Misses       22768    22734      -34     
  Partials      2690     2690

Flag	Coverage Δ
e2e	`54.38% <71.42%> (+0.09%)`	⬆️
unit	`72.34% <ø> (+0.09%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

dougfabris · 2024-06-19T23:32:37Z

if you're going to improve the UX it will change something to the end user, so it shouldn't be a chore

MarcosSpessatto · 2024-06-20T13:27:04Z

if you're going to improve the UX it will change something to the end user, so it shouldn't be a chore

Maybe a fix would fit better in this case, also adding a changeset.

apps/meteor/client/views/room/contextualBar/Info/RoomInfo/Actions.tsx

apps/meteor/client/views/room/contextualBar/Info/RoomInfo/RoomActionsMenu.tsx

apps/meteor/client/views/room/contextualBar/Info/hooks/useRoomActions.ts

dougfabris · 2024-06-21T15:52:42Z

@tiagoevanp if you're improving, it's not a fix 😞

apps/meteor/client/views/room/contextualBar/Info/hooks/useRoomActions.ts

…ovement/room-info-ux

apps/meteor/client/views/room/contextualBar/Info/hooks/useSplitRoomActions.ts

apps/meteor/tests/e2e/page-objects/fragments/home-flextab-room.ts

apps/meteor/tests/e2e/channel-management.spec.ts

…tRoomActions.ts Co-authored-by: Douglas Fabris <devfabris@gmail.com>

Co-authored-by: Douglas Fabris <devfabris@gmail.com>

…ovement/room-info-ux

dougfabris

LGTM!

…ovement/room-info-ux

…threadEdit * 'develop' of github.com:RocketChat/Rocket.Chat: feat: Improve UX from "Action Buttons" in `RoomInfo` (#32632) fix: Attachments not downloading on non-encrypted rooms (#32837)

improve

ce08c89

tiagoevanp changed the title ~~chore: Change "Action Buttons design~~ chore: Change "Action Buttons" design Jun 19, 2024

tiagoevanp changed the title ~~chore: Change "Action Buttons" design~~ chore: Improve UX from "Action Buttons" in RoomInfo Jun 19, 2024

test

78a847b

tiagoevanp marked this pull request as ready for review June 19, 2024 19:27

tiagoevanp requested a review from a team as a code owner June 19, 2024 19:27

tiagoevanp added this to the 6.10 milestone Jun 19, 2024

Merge branch 'develop' into improvement/room-info-ux

3eac10b

tiagoevanp changed the title ~~chore: Improve UX from "Action Buttons" in RoomInfo~~ fix: Improve UX from "Action Buttons" in RoomInfo Jun 20, 2024

Create weak-insects-sort.md

a57956c

MarcosSpessatto previously approved these changes Jun 20, 2024

View reviewed changes

tiagoevanp added 2 commits June 20, 2024 13:58

Merge branch 'develop' into improvement/room-info-ux

e677ea2

fix broken e2e tests

1bd7411

tiagoevanp dismissed MarcosSpessatto’s stale review via 1bd7411 June 20, 2024 21:16

dougfabris requested changes Jun 21, 2024

View reviewed changes

scuciatto removed this from the 6.10 milestone Jun 21, 2024

tiagoevanp modified the milestone: 6.10 Jun 21, 2024

dougfabris reviewed Jun 21, 2024

View reviewed changes

apps/meteor/client/views/room/contextualBar/Info/hooks/useRoomActions.ts Outdated Show resolved Hide resolved

review

82661bc

tiagoevanp changed the title ~~fix: Improve UX from "Action Buttons" in RoomInfo~~ feat: Improve UX from "Action Buttons" in RoomInfo Jun 24, 2024

MarcosSpessatto requested a review from dougfabris June 24, 2024 13:02

tiagoevanp added 2 commits June 26, 2024 16:39

Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into impr…

acedbbb

…ovement/room-info-ux

split hook in two

3a76a56

eslint fix

62cee41

dougfabris requested changes Jun 27, 2024

View reviewed changes

tiagoevanp and others added 4 commits June 27, 2024 14:14

Update apps/meteor/client/views/room/contextualBar/Info/hooks/useSpli…

e7826ed

…tRoomActions.ts Co-authored-by: Douglas Fabris <devfabris@gmail.com>

Update apps/meteor/client/views/room/contextualBar/Info/hooks/useSpli…

1f73471

…tRoomActions.ts Co-authored-by: Douglas Fabris <devfabris@gmail.com>

Apply suggestions from code review

542ee51

Co-authored-by: Douglas Fabris <devfabris@gmail.com>

Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into impr…

a905bb5

…ovement/room-info-ux

tiagoevanp requested a review from dougfabris June 27, 2024 17:57

dougfabris previously approved these changes Jun 27, 2024

View reviewed changes

scuciatto added this to the 6.11 milestone Jul 3, 2024

scuciatto added the stat: QA assured Means it has been tested and approved by a company insider label Jul 17, 2024

dionisio-bot bot added the stat: conflict label Jul 17, 2024

Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into impr…

9bee628

…ovement/room-info-ux

tiagoevanp dismissed dougfabris’s stale review via 9bee628 July 17, 2024 17:55

dionisio-bot bot removed the stat: conflict label Jul 17, 2024

dougfabris previously approved these changes Jul 17, 2024

View reviewed changes

typecheck conflict

d1aaf68

tiagoevanp dismissed dougfabris’s stale review via d1aaf68 July 17, 2024 18:19

dougfabris approved these changes Jul 19, 2024

View reviewed changes

dougfabris added the stat: ready to merge PR tested and approved waiting for merge label Jul 19, 2024

kodiakhq bot added 5 commits July 19, 2024 19:36

Merge branch 'develop' into improvement/room-info-ux

640b87f

Merge branch 'develop' into improvement/room-info-ux

79b574a

Merge branch 'develop' into improvement/room-info-ux

c76bd87

Merge branch 'develop' into improvement/room-info-ux

bc53284

Merge branch 'develop' into improvement/room-info-ux

e08a7a2

kodiakhq bot merged commit 5bfde8d into develop Jul 22, 2024

kodiakhq bot deleted the improvement/room-info-ux branch July 22, 2024 17:37

rocketchat-github-ci mentioned this pull request Jul 25, 2024

Release 6.11.0 #32901

Merged

debdutdeb pushed a commit that referenced this pull request Jul 31, 2024

feat: Improve UX from "Action Buttons" in RoomInfo (#32632)

e52db95

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Improve UX from "Action Buttons" in `RoomInfo`#32632

feat: Improve UX from "Action Buttons" in `RoomInfo`#32632
kodiakhq[bot] merged 21 commits intodevelopfrom
improvement/room-info-ux

tiagoevanp commented Jun 19, 2024 •

edited by atlassian bot

Loading

Uh oh!

dionisio-bot bot commented Jun 19, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Jun 19, 2024 •

edited

Loading

Uh oh!

codecov bot commented Jun 19, 2024 •

edited

Loading

Uh oh!

dougfabris commented Jun 19, 2024

Uh oh!

MarcosSpessatto commented Jun 20, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dougfabris commented Jun 21, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dougfabris left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

tiagoevanp commented Jun 19, 2024 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Uh oh!

dionisio-bot bot commented Jun 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Jun 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

codecov bot commented Jun 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dougfabris commented Jun 19, 2024

Uh oh!

MarcosSpessatto commented Jun 20, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dougfabris commented Jun 21, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dougfabris left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tiagoevanp commented Jun 19, 2024 •

edited by atlassian bot

Loading

dionisio-bot bot commented Jun 19, 2024 •

edited

Loading

changeset-bot bot commented Jun 19, 2024 •

edited

Loading

codecov bot commented Jun 19, 2024 •

edited

Loading