fix: Attachments not downloading on non-encrypted rooms#32837
Merged
kodiakhq[bot] merged 4 commits intodevelopfrom Jul 22, 2024
Merged
fix: Attachments not downloading on non-encrypted rooms#32837kodiakhq[bot] merged 4 commits intodevelopfrom
kodiakhq[bot] merged 4 commits intodevelopfrom
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: bf5b8f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32837 +/- ##
===========================================
- Coverage 55.60% 55.55% -0.06%
===========================================
Files 2635 2635
Lines 57289 57292 +3
Branches 11864 11865 +1
===========================================
- Hits 31858 31826 -32
- Misses 22742 22769 +27
- Partials 2689 2697 +8
Flags with carried forward coverage won't be shown. Click here to find out more. |
Member
|
Tested and is working as intended. |
jessicaschelly
added
stat: QA assured
scuciatto
added
the
stat: ready to merge
Merged
debdutdeb
pushed a commit
that referenced
this pull request
Jul 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The downloading event was trying to decrypt not encrypted files, causing the issue.
Issue(s)
SUP-626
Steps to test or reproduce
Further comments