feat(apps): add user param to update app call#32719
Merged
kodiakhq[bot] merged 12 commits intodevelopfrom Jul 17, 2024
Merged
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 1e88e83 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32719 +/- ##
===========================================
+ Coverage 51.72% 55.51% +3.78%
===========================================
Files 2346 2634 +288
Lines 52717 57215 +4498
Branches 10871 11849 +978
===========================================
+ Hits 27269 31761 +4492
+ Misses 23068 22760 -308
- Partials 2380 2694 +314
Flags with carried forward coverage won't be shown. Click here to find out more. |
d-gubert
reviewed
Jul 11, 2024
d-gubert
reviewed
Jul 12, 2024
d-gubert
approved these changes
Jul 17, 2024
Merged
debdutdeb
pushed a commit
that referenced
this pull request
Jul 31, 2024
Co-authored-by: Douglas Gubert <1810309+d-gubert@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Added the
userparam to apps-engine update method call, allowing apps' newonUpdatehook to know who triggered the update.Issue(s)
Steps to test or reproduce
Further comments
Merge only after: RocketChat/Rocket.Chat.Apps-engine#778