Skip to content

feat(apps): add user param to update app call#32719

Merged
kodiakhq[bot] merged 12 commits intodevelopfrom
feat/user-to-update-app
Jul 17, 2024
Merged

feat(apps): add user param to update app call#32719
kodiakhq[bot] merged 12 commits intodevelopfrom
feat/user-to-update-app

Conversation

@KevLehman
Copy link
Copy Markdown
Member

@KevLehman KevLehman commented Jul 3, 2024

Proposed changes (including videos or screenshots)

Added the user param to apps-engine update method call, allowing apps' new onUpdate hook to know who triggered the update.

Issue(s)

Steps to test or reproduce

Further comments

Merge only after: RocketChat/Rocket.Chat.Apps-engine#778

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Jul 3, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jul 3, 2024

🦋 Changeset detected

Latest commit: 1e88e83

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/core-typings Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/rest-typings Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/ddp-client Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.51%. Comparing base (bed824f) to head (1e88e83).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32719      +/-   ##
===========================================
+ Coverage    51.72%   55.51%   +3.78%     
===========================================
  Files         2346     2634     +288     
  Lines        52717    57215    +4498     
  Branches     10871    11849     +978     
===========================================
+ Hits         27269    31761    +4492     
+ Misses       23068    22760     -308     
- Partials      2380     2694     +314     
Flag Coverage Δ
e2e 54.25% <ø> (+7.76%) ⬆️
unit 72.08% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman requested a review from d-gubert July 8, 2024 19:21
@d-gubert d-gubert marked this pull request as ready for review July 11, 2024 23:58
@d-gubert d-gubert requested review from a team as code owners July 11, 2024 23:58
@d-gubert d-gubert changed the title chore: Add user param to update app call feat(apps): add user param to update app call Jul 12, 2024
@d-gubert d-gubert added this to the 6.11 milestone Jul 17, 2024
@d-gubert d-gubert added the stat: QA assured Means it has been tested and approved by a company insider label Jul 17, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 17, 2024
@kodiakhq kodiakhq bot merged commit b8e5887 into develop Jul 17, 2024
@kodiakhq kodiakhq bot deleted the feat/user-to-update-app branch July 17, 2024 23:09
debdutdeb pushed a commit that referenced this pull request Jul 31, 2024
Co-authored-by: Douglas Gubert <1810309+d-gubert@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants