Skip to content

feat(apps): add user param to update app call #32719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 12 commits into from
Jul 17, 2024
Merged

feat(apps): add user param to update app call #32719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
8907bf0
Add user param to update app call
KevLehman Jul 3, 2024
13e3cdc
Merge branch 'develop' into feat/user-to-update-app
d-gubert Jul 11, 2024
faf26a8
Convert user object before sending to app update method
d-gubert Jul 11, 2024
99f2415
Update Apps-engine version
d-gubert Jul 11, 2024
ce6cb1c
Create witty-bats-develop.md
KevLehman Jul 11, 2024
c66c04e
Update .changeset/witty-bats-develop.md
d-gubert Jul 11, 2024
f3b4935
Update .changeset/witty-bats-develop.md
d-gubert Jul 12, 2024
02fce57
Merge branch 'develop' into feat/user-to-update-app
KevLehman Jul 12, 2024
5a38df5
Merge remote-tracking branch 'origin/develop' into feat/user-to-updat…
d-gubert Jul 12, 2024
e26710b
Merge remote-tracking branch 'origin/develop' into feat/user-to-updat…
d-gubert Jul 17, 2024
abe3172
Merge branch 'develop' into feat/user-to-update-app
kodiakhq[bot] Jul 17, 2024
1e88e83
Merge branch 'develop' into feat/user-to-update-app
kodiakhq[bot] Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .changeset/witty-bats-develop.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
---
"@rocket.chat/meteor": patch
"@rocket.chat/apps": patch
"@rocket.chat/core-services": patch
"@rocket.chat/core-typings": patch
"@rocket.chat/fuselage-ui-kit": patch
"@rocket.chat/rest-typings": patch
"@rocket.chat/ddp-streamer": patch
"@rocket.chat/presence": patch
"rocketchat-services": patch
---

Added the `user` param to apps-engine update method call, allowing apps' new `onUpdate` hook to know who triggered the update.
7 changes: 6 additions & 1 deletion apps/meteor/ee/server/apps/communication/rest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -747,7 +747,12 @@ export class AppsRestApi {
return API.v1.internalError('private_app_install_disabled');
}

const aff = await manager.update(buff, permissionsGranted);
const user = orchestrator
?.getConverters()
?.get('users')
?.convertToApp(await Meteor.userAsync());

const aff = await manager.update(buff, permissionsGranted, { user, loadApp: true });
const info: IAppInfo & { status?: AppStatus } = aff.getAppInfo();

if (aff.hasStorageError()) {
Expand Down
6 changes: 3 additions & 3 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8510,8 +8510,8 @@ __metadata:
linkType: soft

"@rocket.chat/apps-engine@npm:alpha":
version: 1.44.0-alpha.814
resolution: "@rocket.chat/apps-engine@npm:1.44.0-alpha.814"
version: 1.44.0-alpha.818
resolution: "@rocket.chat/apps-engine@npm:1.44.0-alpha.818"
dependencies:
"@msgpack/msgpack": 3.0.0-beta2
adm-zip: ^0.5.9
Expand All @@ -8527,7 +8527,7 @@ __metadata:
uuid: ~8.3.2
peerDependencies:
"@rocket.chat/ui-kit": "*"
checksum: 03f777ecd035af20c88558a941db77bb104f4402f78169a6d23e1629613c11ac23c04f6bdfb451a4273558789de58d4567661a7bd5de91b78464f98698e5f6a6
checksum: acef47bc7f13e0682d018531638b5168c3acd59beae37b013e881ea6fadfe12670fe10545f4a89487f7bedbe9166028833cba7ed3fc401d4283327e47e00e61c
languageName: node
linkType: hard

Expand Down