fix: Create discussion form Create button is disabled when starting discussion from message#32864
Merged
fix: Create discussion form Create button is disabled when starting discussion from message#32864
Create button is disabled when starting discussion from message#32864Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: ebcb0d6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32864 +/- ##
===========================================
- Coverage 55.46% 50.65% -4.82%
===========================================
Files 2635 2193 -442
Lines 57343 50459 -6884
Branches 11874 10325 -1549
===========================================
- Hits 31807 25561 -6246
+ Misses 22842 22674 -168
+ Partials 2694 2224 -470
Flags with carried forward coverage won't be shown. Click here to find out more. |
MarcosSpessatto
previously approved these changes
Jul 23, 2024
dougfabris
requested changes
Jul 23, 2024
Member
dougfabris
left a comment
dougfabris
left a comment
There was a problem hiding this comment.
We could just remove the disabled prop based on isDirty as we discussed privately
…hat into fix/createDiscussion * 'fix/createDiscussion' of github.com:RocketChat/Rocket.Chat: Add cs
dougfabris
approved these changes
Jul 23, 2024
dougfabris
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
MarcosSpessatto
approved these changes
Jul 23, 2024
Merged
debdutdeb
pushed a commit
that referenced
this pull request
Jul 31, 2024
… discussion from message (#32864)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
When creating a discussion from a message the
createbutton is disabled, although parent channel and name are prefilled.This PR fixes this issue, making sure the button is enabled.
Issue(s)
CORE-573
Steps to test or reproduce
Further comments