Skip to content

regression: Messagebox sending message instead of just selecting popup suggestion#32890

Merged
ggazzo merged 1 commit intodevelopfrom
reg/messageBoxPopup
Jul 26, 2024
Merged

regression: Messagebox sending message instead of just selecting popup suggestion#32890
ggazzo merged 1 commit intodevelopfrom
reg/messageBoxPopup

Conversation

@gabriellsh
Copy link
Copy Markdown
Member

@gabriellsh gabriellsh commented Jul 24, 2024 •
edited by atlassian bot
Loading

Proposed changes (including videos or screenshots)

The way events were being attached changed and affected the popup and messagebox behaviour. When tagging or selecting another suggestion, it's currently filling the messagebox with the suggestion and sending the message at the same time.

This PR fixes this and adds tests to ensure this behaviour doesn't happen again.

Issue(s)

Introduced here: #32861
CORE-577

Steps to test or reproduce

Further comments

@gabriellsh gabriellsh requested a review from a team as a code owner July 24, 2024 15:13
@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Jul 24, 2024 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jul 24, 2024

⚠️ No Changeset found

Latest commit: ceae1f7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gabriellsh gabriellsh added this to the 6.11 milestone Jul 24, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 55.62%. Comparing base (393e613) to head (ceae1f7).
Report is 13 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32890      +/-   ##
===========================================
+ Coverage    55.49%   55.62%   +0.12%     
===========================================
  Files         2637     2637              
  Lines        57393    57393              
  Branches     11892    11892              
===========================================
+ Hits         31852    31922      +70     
+ Misses       22847    22771      -76     
- Partials      2694     2700       +6
Flag Coverage Δ
e2e 54.30% <25.00%> (+0.22%) ⬆️
unit 72.23% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tiagoevanp tiagoevanp mentioned this pull request Jul 24, 2024
Closed
jessicaschelly
jessicaschelly reviewed Jul 25, 2024
View reviewed changes
apps/meteor/tests/e2e/message-composer.spec.ts

await expect(poHomeChannel.composer).toHaveValue('/gimme ');

await poHomeChannel.composer.fill('');
Copy link
Copy Markdown
Member

@jessicaschelly jessicaschelly Jul 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could move this to an afterEach? Since it could be helpful for the other tests as well

Copy link
Copy Markdown
Member

@ggazzo ggazzo Jul 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If having the input empty is a prerequisite, it should be in the beforeEach. and one after all to cleanup

also is not type deprecated?

Copy link
Copy Markdown
Member Author

@gabriellsh gabriellsh Jul 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case I decided to use test and test.step, which does not provider before/after callbacks. This decision was made to favor performance of the tests, since have one test for each of those would open a new page during execution.

@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Jul 25, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 25, 2024
@ggazzo ggazzo merged commit 7c5eac8 into develop Jul 26, 2024
@ggazzo ggazzo deleted the reg/messageBoxPopup branch July 26, 2024 18:44
ggazzo pushed a commit that referenced this pull request Jul 26, 2024
@gabriellsh @ggazzo
regression: Messagebox sending message instead of just selecting popu…
d26eb5b 
…p suggestion (#32890)
gabriellsh added a commit that referenced this pull request Jul 31, 2024
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into impr…
c93b920 
…ove/threadMetrics

* 'develop' of github.com:RocketChat/Rocket.Chat: (26 commits)
  chore: Bump rocket.chat to 6.12.0-develop (#32936)
  test: Move Jest configuration to a package of presets (#32802)
  chore: bump turbo (#32938)
  feat: New users page deactivated tab and active tab ui (#32032)
  chore: bump traefik (#32892)
  test: fix flaky test `Archive department` (#32933)
  fix(Livechat): `After Registration Triggers` showing in wrong screen (#32928)
  refactor: Remove deprecated `Options.AvatarSize` constant (#32909)
  chore: improve `on login` cached collection (#32929)
  i18n: Rocket.Chat language update from Lingohub 🤖 on 2024-07-25Z (#32908)
  refactor: Circular imports (#32885)
  regression: notify user properly on logout (#32920)
  chore(client): stop replacing  `Meteor.user` (#32910)
  regression: Messagebox sending message instead of just selecting popup suggestion (#32890)
  refactor: move broadcastMessageFromData to notifyListener (#32843)
  chore: prevent destructuring _id of deleted users (#32899)
  ci: increase kernel limits (#32902)
  ci: lint issues
  Release 6.10.1
  fix: imported fixes (#32894)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggazzo ggazzo ggazzo left review comments

@jessicaschelly jessicaschelly jessicaschelly left review comments

+1 more reviewer

@tiagoevanp tiagoevanp tiagoevanp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Milestone

6.11

Development

Successfully merging this pull request may close these issues.

4 participants

@gabriellsh @ggazzo @tiagoevanp @jessicaschelly