fix: Pressing esc whilst editing a message closes the contextual bar#32861
Merged
kodiakhq[bot] merged 7 commits intodevelopfrom Jul 22, 2024
Merged
fix: Pressing esc whilst editing a message closes the contextual bar#32861kodiakhq[bot] merged 7 commits intodevelopfrom
kodiakhq[bot] merged 7 commits intodevelopfrom
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: f6de7b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32861 +/- ##
===========================================
- Coverage 55.59% 55.55% -0.05%
===========================================
Files 2637 2637
Lines 57308 57313 +5
Branches 11868 11869 +1
===========================================
- Hits 31860 31839 -21
- Misses 22754 22767 +13
- Partials 2694 2707 +13
Flags with carried forward coverage won't be shown. Click here to find out more. |
dougfabris
approved these changes
Jul 22, 2024
dougfabris
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Merged
debdutdeb
pushed a commit
that referenced
this pull request
Jul 31, 2024
…32861) Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
There's 2 ways to attach an event listener to a component, using react props (onClick, onKeyDown, etc) or directly to the node (using a callbackRef or getting the element directly from the dom). Attaching events using both ways changes how event propagation works due to react's synthetic event handlers.
The issue was resolved by adding the composer keydown event using a callbackRef instead of as a prop.
Issue(s)
Steps to test or reproduce
Further comments
CORE-529