Skip to content

test: Move Jest configuration to a package of presets#32802

Merged
ggazzo merged 9 commits intodevelopfrom
refactor/jest-presets
Jul 30, 2024
Merged

test: Move Jest configuration to a package of presets#32802
ggazzo merged 9 commits intodevelopfrom
refactor/jest-presets

Conversation

@tassoevan
Copy link
Copy Markdown
Member

@tassoevan tassoevan commented Jul 16, 2024

Proposed changes (including videos or screenshots)

This pull request unifies Jest configurations in a package of presets (@rocket.chat/jest-presets).

Issue(s)

Steps to test or reproduce

Further comments

It was extracted from #32550 and only covers the workspace /apps/meteor for now.

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Jul 16, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 6.12.0, but it targets 6.11.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jul 16, 2024

⚠️ No Changeset found

Latest commit: 2b7aabe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.94%. Comparing base (851d60a) to head (2b7aabe).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32802      +/-   ##
===========================================
- Coverage    55.66%   54.94%   -0.73%     
===========================================
  Files         2637     2595      -42     
  Lines        57399    55990    -1409     
  Branches     11892    11559     -333     
===========================================
- Hits         31954    30763    -1191     
+ Misses       22731    22575     -156     
+ Partials      2714     2652      -62     
Flag Coverage Δ
e2e 54.29% <100.00%> (+<0.01%) ⬆️
unit 72.98% <ø> (+0.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan force-pushed the refactor/jest-presets branch 3 times, most recently from 69d062e to b7aa047 Compare July 19, 2024 05:47
@tassoevan tassoevan force-pushed the refactor/jest-presets branch from b7aa047 to 237afa7 Compare July 19, 2024 15:21
@tassoevan tassoevan marked this pull request as ready for review July 19, 2024 17:48
@tassoevan tassoevan requested review from a team as code owners July 19, 2024 17:48
@tassoevan tassoevan changed the title refactor(tests): Move Jest configuration to a package of presets test: Move Jest configuration to a package of presets Jul 19, 2024
ggazzo
ggazzo previously approved these changes Jul 19, 2024
@tassoevan tassoevan added this to the 6.11 milestone Jul 22, 2024
sampaiodiego
sampaiodiego previously approved these changes Jul 23, 2024
@sampaiodiego sampaiodiego added the stat: QA assured Means it has been tested and approved by a company insider label Jul 23, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 23, 2024
@ggazzo ggazzo modified the milestones: 6.11, 6.12 Jul 24, 2024
@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Jul 26, 2024
@kodiakhq
Copy link
Copy Markdown
Contributor

kodiakhq bot commented Jul 26, 2024

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@tassoevan tassoevan dismissed stale reviews from sampaiodiego and ggazzo via 0c632ae July 29, 2024 13:49
@ggazzo ggazzo merged commit 1b072df into develop Jul 30, 2024
@ggazzo ggazzo deleted the refactor/jest-presets branch July 30, 2024 18:35
gabriellsh added a commit that referenced this pull request Jul 31, 2024
…ove/threadMetrics

* 'develop' of github.com:RocketChat/Rocket.Chat: (26 commits)
  chore: Bump rocket.chat to 6.12.0-develop (#32936)
  test: Move Jest configuration to a package of presets (#32802)
  chore: bump turbo (#32938)
  feat: New users page deactivated tab and active tab ui (#32032)
  chore: bump traefik (#32892)
  test: fix flaky test `Archive department` (#32933)
  fix(Livechat): `After Registration Triggers` showing in wrong screen (#32928)
  refactor: Remove deprecated `Options.AvatarSize` constant (#32909)
  chore: improve `on login` cached collection (#32929)
  i18n: Rocket.Chat language update from Lingohub 🤖 on 2024-07-25Z (#32908)
  refactor: Circular imports (#32885)
  regression: notify user properly on logout (#32920)
  chore(client): stop replacing  `Meteor.user` (#32910)
  regression: Messagebox sending message instead of just selecting popup suggestion (#32890)
  refactor: move broadcastMessageFromData to notifyListener (#32843)
  chore: prevent destructuring _id of deleted users (#32899)
  ci: increase kernel limits (#32902)
  ci: lint issues
  Release 6.10.1
  fix: imported fixes (#32894)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants