Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
91a8574 to
5a40f2d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32885 +/- ##
===========================================
- Coverage 55.48% 55.48% -0.01%
===========================================
Files 2636 2636
Lines 57365 57499 +134
Branches 11881 11917 +36
===========================================
+ Hits 31831 31905 +74
- Misses 22837 22905 +68
+ Partials 2697 2689 -8
Flags with carried forward coverage won't be shown. Click here to find out more. |
5a40f2d to
26ce896
Compare
pierre-lehnen-rc
left a comment
There was a problem hiding this comment.
While reviewing I noticed some things (unaffected by this PR, but related to the same stuff that was changed):
- We stil have a few meteor methods on the client, but they are using the types defined on the
ServerMethodsinterface. - Some of the apps on /ee/apps are importing files from the main meteor app and those files in turn are importing other packages like
@rocket.chat/string-helpers, which are not being copied along on the app's Dockerfile. If something on those apps tried to call one of the functions imported from those packages, it would crash.
…ove/threadMetrics * 'develop' of github.com:RocketChat/Rocket.Chat: (26 commits) chore: Bump rocket.chat to 6.12.0-develop (#32936) test: Move Jest configuration to a package of presets (#32802) chore: bump turbo (#32938) feat: New users page deactivated tab and active tab ui (#32032) chore: bump traefik (#32892) test: fix flaky test `Archive department` (#32933) fix(Livechat): `After Registration Triggers` showing in wrong screen (#32928) refactor: Remove deprecated `Options.AvatarSize` constant (#32909) chore: improve `on login` cached collection (#32929) i18n: Rocket.Chat language update from Lingohub 🤖 on 2024-07-25Z (#32908) refactor: Circular imports (#32885) regression: notify user properly on logout (#32920) chore(client): stop replacing `Meteor.user` (#32910) regression: Messagebox sending message instead of just selecting popup suggestion (#32890) refactor: move broadcastMessageFromData to notifyListener (#32843) chore: prevent destructuring _id of deleted users (#32899) ci: increase kernel limits (#32902) ci: lint issues Release 6.10.1 fix: imported fixes (#32894) ...
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments