chore(client): stop replacing Meteor.user

[ggazzo]

After a change in Meteor (meteor 3.0.0), where Accounts.callLoginMethod trusts that Accounts.user.find is still there to call the login callbacks, it became clear that it is not healthy to rewrite internal framework objects.

...
...
But no one has proof that adding extra methods causes problems :)

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

CORE-578

[changeset-bot]

⚠️ No Changeset found

Latest commit: 5d24a88

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is targeting the wrong base branch. It should target 6.12.0, but it targets 6.11.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.53%. Comparing base (978e2d1) to head (5d24a88).
Report is 4 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #32910   +/-   ##
========================================
  Coverage    55.53%   55.53%           
========================================
  Files         2637     2637           
  Lines        57439    57443    +4     
  Branches     11903    11906    +3     
========================================
+ Hits         31897    31900    +3     
+ Misses       22823    22822    -1     
- Partials      2719     2721    +2     

Flag	Coverage Δ
e2e	54.06% <100.00%> (+<0.01%)	⬆️
unit	72.36% <100.00%> (+0.05%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[matheusbsilva137]

Just trying to understand: why are we removing this?
Shouldn't we keep redirecting the user to the homepage in case they are already logged in RC when accessing this page?

[ggazzo]

Pierre had done a workaround, for some reason, in Meteor 3.0.0 this callback would never be called. However, in Meteor 2.0.0 it happens.

If you stop to think about it, it doesn't make sense to redirect the user after logging in if he doesn't have a uid, because that means it failed.

Likewise, it doesn't make sense to redirect twice if it works.

You even did a test to see if it redirects to the home page twice, that's going to be quite interesting.

[pierre-lehnen-rc]

Looking at this file now, one thing that I find weird is that we're doing the redirects (to home or to redirectUrl) even if the callback is called with an error. Shouldn't this happen only on successful login (specially for the redirectUrl)?

I think we should add an extra test forcing some kind of error to happen on this last step of the login method to ensure the client is behaving as it should.
We have e2e tests for errors on loginWithSaml, but none with errors on loginWithSamlToken. On the unit tests for the view, the mocked function never sends any errors.