Skip to content

chore: make SAML login redirect ready for Meteor 3.0#32907

Closed
matheusbsilva137 wants to merge 3 commits intodevelopfrom
chore/saml-redirect-meteor-3
Closed

chore: make SAML login redirect ready for Meteor 3.0#32907
matheusbsilva137 wants to merge 3 commits intodevelopfrom
chore/saml-redirect-meteor-3

Conversation

@matheusbsilva137
Copy link
Copy Markdown
Contributor

@matheusbsilva137 matheusbsilva137 commented Jul 25, 2024

Proposed changes (including videos or screenshots)

  • Avoid relying in Meteor.loginWithSamlToken's callback (since it's not reliable in Meteor 3.0).

Issue(s)

Steps to test or reproduce

Further comments

CORE-578

@matheusbsilva137 matheusbsilva137 added this to the 6.12 milestone Jul 25, 2024
@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Jul 25, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 6.12.0, but it targets 6.11.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jul 25, 2024

⚠️ No Changeset found

Latest commit: 1c23564

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.54%. Comparing base (7442ffc) to head (1c23564).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32907      +/-   ##
===========================================
+ Coverage    55.51%   55.54%   +0.03%     
===========================================
  Files         2637     2637              
  Lines        57439    57453      +14     
  Branches     11903    11908       +5     
===========================================
+ Hits         31887    31913      +26     
+ Misses       22832    22822      -10     
+ Partials      2720     2718       -2     
Flag Coverage Δ
e2e 54.09% <40.00%> (+0.07%) ⬆️
unit 72.36% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@pierre-lehnen-rc
Copy link
Copy Markdown
Contributor

Closing it as it's no longer needed thanks to #32910

@tassoevan tassoevan deleted the chore/saml-redirect-meteor-3 branch July 30, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants