Skip to content

chore: Exclude Storybook stories from the build of @rocket.chat/ui-composer#32944

Merged
ggazzo merged 1 commit intodevelopfrom
chore/exclude-stories-from-build
Aug 1, 2024
Merged

chore: Exclude Storybook stories from the build of @rocket.chat/ui-composer#32944
ggazzo merged 1 commit intodevelopfrom
chore/exclude-stories-from-build

Conversation

@tassoevan
Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

It removes modules compiled from *.stories.tsx files from the final build of @rocket.chat/ui-composer.

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Jul 30, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jul 30, 2024

⚠️ No Changeset found

Latest commit: 3f75419

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tassoevan tassoevan requested a review from a team July 30, 2024 20:55
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.96%. Comparing base (8fb9ef0) to head (3f75419).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #32944   +/-   ##
========================================
  Coverage    54.96%   54.96%           
========================================
  Files         2595     2595           
  Lines        55993    55993           
  Branches     11593    11593           
========================================
  Hits         30779    30779           
  Misses       22569    22569           
  Partials      2645     2645           
Flag Coverage Δ
unit 72.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan force-pushed the chore/exclude-stories-from-build branch from 0d62199 to 42681d1 Compare July 31, 2024 04:35
@tassoevan tassoevan force-pushed the chore/exclude-stories-from-build branch from 42681d1 to 3f75419 Compare July 31, 2024 16:03
@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Jul 31, 2024
@ggazzo ggazzo added this to the 6.12 milestone Aug 1, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 1, 2024
@ggazzo ggazzo merged commit a663078 into develop Aug 1, 2024
@ggazzo ggazzo deleted the chore/exclude-stories-from-build branch August 1, 2024 00:13
gabriellsh added a commit that referenced this pull request Aug 5, 2024
…ove/threadMetrics

* 'develop' of github.com:RocketChat/Rocket.Chat: (22 commits)
  chore: saveAnalyticsData with accumulator (#32961)
  regression: fix dispatchInquiryPosition not being fired on room creation (#32972)
  chore: create `orm` for specific cases (#32948)
  chore: create `afterOmnichannelSaveMessage` (#32970)
  fix: `Menu` onPointerUp event behavior (#32968)
  Release 6.11.0-rc.2
  feat: add `Advanced settings` on create Team and Channel (#32867)
  Revert "fix: Login services button colors" (#32955)
  chore: Use index on `unlockAll` query called when changing OM routing methods (#32860)
  chore: Exclude Storybook stories from the build of `@rocket.chat/ui-composer` (#32944)
  chore: Remove `ui-kit` from `yarn fuselage` script (#32942)
  Release 6.10.2
  fix: Client crashing on firefox private window (#32950)
  fix: Apps-Engine patch (#32935)
  test: Remove mockDate and fix unit tests (#32947) (#32949)
  fix: validate `bhType` before registering it (#32931)
  test: Remove mockDate and fix unit tests (#32947)
  Bump 6.10.2
  Release 6.11.0-rc.1
  regression: notify user properly on logout (#32920)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants