Skip to content

chore: create afterOmnichannelSaveMessage#32970

Merged
ggazzo merged 1 commit intodevelopfrom
chore/afterOmnichannelSaveMessage
Aug 2, 2024
Merged

chore: create afterOmnichannelSaveMessage#32970
ggazzo merged 1 commit intodevelopfrom
chore/afterOmnichannelSaveMessage

Conversation

@ggazzo
Copy link
Copy Markdown
Member

@ggazzo ggazzo commented Aug 2, 2024 •
edited by atlassian bot
Loading

The idea is exactly that: a chore, to accommodate future code improvements in a less confusing way.
OPI-9
Basically, the event will only run for omnichannel rooms, making the code simpler and giving us more confidence.

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Aug 2, 2024 •
edited
Loading

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Aug 2, 2024

⚠️ No Changeset found

Latest commit: 1058461

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.97%. Comparing base (e061bd9) to head (1058461).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #32970   +/-   ##
========================================
  Coverage    54.97%   54.97%           
========================================
  Files         2595     2595           
  Lines        55964    55962    -2     
  Branches     11578    11577    -1     
========================================
  Hits         30766    30766           
+ Misses       22555    22553    -2     
  Partials      2643     2643
Flag Coverage Δ
unit 73.00% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review August 2, 2024 17:16
@ggazzo ggazzo requested a review from a team as a code owner August 2, 2024 17:16
@ricardogarim ricardogarim mentioned this pull request Aug 2, 2024
Merged
@ggazzo ggazzo added this to the 6.12 milestone Aug 2, 2024
@ggazzo ggazzo merged commit 24e99a2 into develop Aug 2, 2024
@ggazzo ggazzo deleted the chore/afterOmnichannelSaveMessage branch August 2, 2024 22:22
gabriellsh added a commit that referenced this pull request Aug 5, 2024
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into impr…
e44bb29 
…ove/threadMetrics

* 'develop' of github.com:RocketChat/Rocket.Chat: (22 commits)
  chore: saveAnalyticsData with accumulator (#32961)
  regression: fix dispatchInquiryPosition not being fired on room creation (#32972)
  chore: create `orm` for specific cases (#32948)
  chore: create `afterOmnichannelSaveMessage` (#32970)
  fix: `Menu` onPointerUp event behavior (#32968)
  Release 6.11.0-rc.2
  feat: add `Advanced settings` on create Team and Channel (#32867)
  Revert "fix: Login services button colors" (#32955)
  chore: Use index on `unlockAll` query called when changing OM routing methods (#32860)
  chore: Exclude Storybook stories from the build of `@rocket.chat/ui-composer` (#32944)
  chore: Remove `ui-kit` from `yarn fuselage` script (#32942)
  Release 6.10.2
  fix: Client crashing on firefox private window (#32950)
  fix: Apps-Engine patch (#32935)
  test: Remove mockDate and fix unit tests (#32947) (#32949)
  fix: validate `bhType` before registering it (#32931)
  test: Remove mockDate and fix unit tests (#32947)
  Bump 6.10.2
  Release 6.11.0-rc.1
  regression: notify user properly on logout (#32920)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ricardogarim ricardogarim ricardogarim approved these changes

@KevLehman KevLehman KevLehman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.12

Development

Successfully merging this pull request may close these issues.

3 participants

@ggazzo @ricardogarim @KevLehman